Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove usage of deprecated UIGraphicsBeginImageContextWithOptions #8

Open
wants to merge 1 commit into
base: exodus-fork
Choose a base branch
from

Conversation

mariosvlad
Copy link

@mariosvlad mariosvlad commented Dec 17, 2024

Summary

port of software-mansion@f5503e2 , plus 1 more usage we had in ios/RNSVGNode.m

Remove usage of deprecated UIGraphicsBeginImageContextWithOptions as it was causing some crashes

Test Plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@mariosvlad mariosvlad requested a review from a team December 17, 2024 13:31
@mariosvlad mariosvlad self-assigned this Dec 17, 2024
Copy link

@akinncar akinncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants