Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modernize-use-nullptr #37

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

jrood-nrel
Copy link
Collaborator

No description provided.

@jrood-nrel jrood-nrel requested a review from marchdf July 25, 2024 15:16
@@ -36,7 +36,8 @@
int verbose;

icell = 0;
if (iblank_cell == NULL) iblank_cell = (int*)malloc(sizeof(int) * ncells);
if (iblank_cell == nullptr)
iblank_cell = (int*)malloc(sizeof(int) * ncells);

Check warning

Code scanning / CodeQL

Resource not released in destructor Warning

Resource iblank_cell is acquired by class MeshBlock but not released anywhere in this class.
@@ -92,7 +93,8 @@
}

icell = 0;
if (iblank_cell == NULL) iblank_cell = (int*)malloc(sizeof(int) * ncells);
if (iblank_cell == nullptr)
iblank_cell = (int*)malloc(sizeof(int) * ncells);

Check warning

Code scanning / CodeQL

Resource not released in destructor Warning

Resource iblank_cell is acquired by class MeshBlock but not released anywhere in this class.
@jrood-nrel jrood-nrel merged commit 4a9602e into Exawind:exawind Jul 25, 2024
9 of 10 checks passed
@jrood-nrel jrood-nrel deleted the jrood/nullptr branch July 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants