Regression tests for two-phase solver with empty Nalu-Wind domains #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
mbkuhn
force-pushed
the
mphase_emptydomain_regtests
branch
from
335eb00
to
066a65f
Compare
|
After tonight, when the amr-wind of the tests includes Exawind/amr-wind#1175, then the CPU tests should pass. |
|
I'm getting the tests to pass locally, but they're still failing here. Not sure why. |
|
Tests are now passing with the change to the container (i.e., using the latest amr-wind main instead of latest tagged version: 2.1). |
marchdf
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will need to bring the main/master branches of amr-wind and nalu-wind up to speed with these cases before merging