skip populate_data if requested time is after interpolate time

[mbkuhn]

Summary

Time to debate if this is a good idea...

This is to allow for that fillpatch(new_time) that gets called by the overset solver prior to the timestep starting. The boundary information does not matter at this point in the algorithm; it'll get filled later when necessary. The downside is that the assert is much less strict, i.e., it can't tell between a mistake and this intended exception.

Any alternative would seem to rely on the code knowing whether the timestep (advance) has begun or not, e.g., if advance_states has been called. But that seems pretty complicated to set up.

Pull request type

Please check the type of change introduced:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Checklist

The following is included:

• new unit-test(s)
• new regression test(s)
• documentation for new capability

This PR was tested by running:

• the unit tests
  • on GPU
  • on CPU
• the regression tests
  • on GPU
  • on CPU

Additional background

Issue Number:

[marchdf]

can you have them have different names? maybe this one should be is_overset_advance ? And the other should be set_overset_advance? Or maybe just plain overset_advance

[mbkuhn]

great idea

[mbkuhn]

I think I need them a little more verbose, though

[marchdf]

yeah good point.

[marchdf]

I like where this is going. I just had a minor thought on clarity of naming functions.

[mbkuhn]

The way I set it up should still be correct with multiple iterations in AMR-Wind, too