Multiphase Hybrid - FY24 Q2 milestone (sharpening the pressure field) #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* typo in parser argument * simplify hydrostatic ops * fill internal iblank ghost cells * initialize pressure for sloshing tank case
…ntation) * remove unintended changes too
mbkuhn
force-pushed
the
mphase_hybrid_overset_ops2
branch
from
453ec3c
to
1771c5d
Compare
marchdf
reviewed
Jul 19, 2024
marchdf
requested changes
Jul 19, 2024
marchdf
approved these changes
Jul 22, 2024
marchdf
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the pressure field from Nalu-Wind to be modified according to the sharpening of the interface via terms applied to the pressure gradient.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
This should be accompanied with new unit tests; the reg tests will be in the exawind-driver repo. More checking and refinement to come; I wanted to put it out there. To follow the merging of #1065