Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding CustomKeycard for CustomItems #98

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

VALERA771
Copy link

Description

Describe the changes
Added CustomKeycard class

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why all this check would be needed since basegame already do them

@VALERA771 VALERA771 added the Requires Testing Things need to be verified by an Exiled Developer/Contributor label Sep 18, 2024
@VALERA771
Copy link
Author

I don't see why all this check would be needed since basegame already do them

Wdym? I perform them cuz I override base game permissions for keycard (I know that this is working cuz using it on my server)

@louis1706
Copy link

I don't see why all this check would be needed since basegame already do them

Wdym? I perform them cuz I override base game permissions for keycard (I know that this is working cuz using it on my server)

You could just apply the permission to the keycard your spawning ?!?? And no need to patch

@VALERA771
Copy link
Author

Ah really? Okay...

@VALERA771
Copy link
Author

Wtf event label is added

@louis1706 louis1706 removed the Events label Sep 30, 2024
@louis1706
Copy link

Wtf event label is added

Fix

@github-actions github-actions bot removed the Events label Nov 18, 2024
@louis1706 louis1706 changed the title Adding CustomKeycard for CustomItems feat: Adding CustomKeycard for CustomItems Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API CustomModules Requires Testing Things need to be verified by an Exiled Developer/Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants