Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "OnDroppedAmmo" event does not trigger #373

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

hatulaile
Copy link

Description

Describe the changes
Updated the invoke method from OnDroppedItem to OnDroppedAmmoin the DroppingAmmo patch.

What is the current behavior? (You can also link to an open issue here)
invoke OnDroppedItem

What is the new behavior? (if this is a feature change)
invoke OnDroppedAmmo.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
DropAmmo will no longer invoke DroppedItem

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [may] Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 merged commit 4876861 into ExMod-Team:dev Jan 4, 2025
6 checks passed
dreamsvxyz pushed a commit to DaybreakLabs/Vanced that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants