Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SetFakeScale doesnt execute with currentScale #353

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

AlexInABox
Copy link

https://discord.com/channels/656673194693885975/1002713309876854924/1317978520701501482

Description

Describe the changes
The Player.SetFakeScale method now no longer checks if the proposed fakeScale is the current real scale of the player.

What is the current behavior? (You can also link to an open issue here)
The current behaviour does not allow for the fakeScale to be reset e.g.

What is the new behavior? (if this is a feature change)
The current behaviour does allow for the fakeScale to be reset

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Dec 28, 2024
@AlexInABox AlexInABox changed the title fix: SetFakeScale doesnt excecute with currentScale fix: SetFakeScale doesnt execute with currentScale Dec 28, 2024
@VALERA771 VALERA771 merged commit 5dcd56e into ExMod-Team:dev Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants