Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Player comparing (GetHashCode) #340

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

IRacle1
Copy link

@IRacle1 IRacle1 commented Dec 24, 2024

Description

Describe the changes
Fixes all problems for comparing destroyed player related bug

What is the current behavior? (You can also link to an open issue here)
broke💔

What is the new behavior? (if this is a feature change)
fix👍

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no🥹

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@IRacle1
Copy link
Author

IRacle1 commented Dec 24, 2024

before anyone asks, i cant just remove method, cs compiler starts crying and says to overload all system.object methods, because we already overload Equal

@IRacle1
Copy link
Author

IRacle1 commented Dec 24, 2024

idk who made OldRole property constantly null😭

@IRacle1 IRacle1 merged commit b94e646 into ExMod-Team:dev Dec 24, 2024
6 checks passed
@IRacle1 IRacle1 deleted the another5 branch December 24, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant