Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Chamber.IsOpen #335

Merged
merged 16 commits into from
Dec 27, 2024
Merged

feat: Add Chamber.IsOpen #335

merged 16 commits into from
Dec 27, 2024
+13 −4

Conversation

Rysik5318
Copy link

Description

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Misaka-ZeroTwo and others added 8 commits November 18, 2024 13:42
@Misaka-ZeroTwo
Delete .github/dependabot.yml
15b2b67
@Misaka-ZeroTwo
Update push_nuget.yml
d49166e
@Misaka-ZeroTwo
Update dev.yml
bc641b2
@BoltonDev
ci: add a new workflow to validate pr title (ExMod-Team#312)
e930454 
* ci: add a new workflow to validate pr title

* refactor: edit `pull_request_opened` workflow to add "valide PR title" check

* refactor: remove previous workflow for pr title

* refactor: a small change on the name of each job
@BoltonDev
refactor: missing branches target
161c4ee
@louis1706
Merge branch 'dev'
475c31d
@louis1706
XMAS NW_documentation
ae00da0
@Rysik5318
Update Chamber.cs
c645af9
@github-actions github-actions bot added the API label Dec 24, 2024
@Rysik5318
Copy link
Author

Fuck

@Rysik5318
Copy link
Author

I don't know what else to do :trollface:

louis1706
louis1706 approved these changes Dec 24, 2024
View reviewed changes
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just do what i suggested

@Rysik5318
Copy link
Author

@louis1706

@louis1706
Copy link

@louis1706

Yeah i didn't Believe you used this références are you sure it's work i would believe than it's client sided when using audio clip

@Rysik5318
Copy link
Author

I checked, you're completely right

@Rysik5318
Copy link
Author

Hmm, it still doesn't work, I'll have to do it.....

@Rysik5318
Copy link
Author

That's the only way

@louis1706
Copy link

That's the only way

Have you tested it ?

@Rysik5318
Copy link
Author

That's the only way

Have you tested it ?

Yes. @louis1706

@Rysik5318 Rysik5318 changed the base branch from master to dev December 24, 2024 23:40
@Banalny-Banan
Copy link

Banalny-Banan commented Dec 25, 2024 •
edited
Loading

The only question I have is why exactly is in not in master… Like, lockers do need a property for being open on not, why wasnt it there in the first place

@louis1706
Copy link

The only question I have is why exactly is in not in master… Like, lockers do need a property for being open on not, why wasnt it there in the first place

because Locker can have multiple chamber so you can't say it's open or not

@Rysik5318
Copy link
Author

@louis1706

@louis1706 louis1706 merged commit bcbffda into ExMod-Team:dev Dec 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis1706 louis1706 louis1706 approved these changes

Assignees

@Rysik5318 Rysik5318

Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rysik5318 @louis1706 @Banalny-Banan @LumiFae @Misaka-ZeroTwo @BoltonDev