Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Objective wrappers #316

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

VALERA771
Copy link

Description

Describe the changes
Adding wrappers for Objective instances. Possible new objectives will be added soon (ScpObjectiveBase is not used...)

What is the current behavior? (You can also link to an open issue here)
No wrappers

What is the new behavior? (if this is a feature change)
Profit

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
I don't know english so idk what to write in docs. Pls help me ;(


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

they seem kinda useless but yamato wasnts them so ok
@VALERA771 VALERA771 changed the title Objective feat: Objective wrappers Dec 18, 2024
@github-actions github-actions bot added the API label Dec 18, 2024
@louis1706 louis1706 changed the base branch from scpsl14 to dev December 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant