-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Speaker Toy #250
base: dev
Are you sure you want to change the base?
feat: Speaker Toy #250
Conversation
There is already a pull request that adds the speaker toy, you should contribute on it (#235) |
talked already to nameless she doesn't update it or adds anything so that's why i did a separate one |
Completed the Speaker API Wrapper w/ NotZer0Two
Final Credits for everything goes to
Example of playing audio:
Proof of it working: |
Yeah I wasn't planning to add Play or anything, so this PR is fine |
The only issue we encountered so far its not on our side but on NW Side where the audio glitches out if multiple speaker are nearby |
Updated Doc's and made is playing public
# Conflicts: # EXILED/Exiled.API/Features/Toys/Speaker.cs
Well now you need to solve the original issue of playback continuing after round restart |
Added what you asked for... |
Like can we push it and just end this here? because its like a month of this being open and getting fixes for stuff not needed |
Updated the Create method, we don't need to have Scale, or Rotation.
Is there anything else that needs to get changed? Sorry if I'm sounding a bit impatient, I just want to use this exiled wrapper instead of my own variation and with that a lot of code to change to replace said variation. |
I'm sorry, but what's the problem? When we are going to have this pr I don't want to use a separate audio api |
The exiled higher ups are lazy and don't want to merge it because it would require adding a new dependency |
We just have other priorities, such as other projects, life and yk having a stable version, there are still bugs to fix rn. Also as it currently stands, although minor, there is a breaking change which means this can't be merged into EXILED9 while it has that. |
Description
Describe the changes
Adding the SpeakerToy Apis
What is the current behavior? (You can also link to an open issue here)
None
What is the new behavior? (if this is a feature change)
None
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Requires help from anyone for the playing method
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other