Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Speaker Toy #250

Open
wants to merge 32 commits into
base: dev
Choose a base branch
from
Open

feat: Speaker Toy #250

wants to merge 32 commits into from

Conversation

NotZer0Two
Copy link

Description

Describe the changes
Adding the SpeakerToy Apis

What is the current behavior? (You can also link to an open issue here)
None

What is the new behavior? (if this is a feature change)
None

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Requires help from anyone for the playing method


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@NotZer0Two NotZer0Two changed the base branch from master to scpsl14 November 28, 2024 15:17
@BoltonDev
Copy link

There is already a pull request that adds the speaker toy, you should contribute on it (#235)

@NotZer0Two
Copy link
Author

There is already a pull request that adds the speaker toy, you should contribute on it (#235)

talked already to nameless she doesn't update it or adds anything so that's why i did a separate one

@NotZer0Two NotZer0Two changed the title Speaker Toy (W.I.P) Speaker Toy Nov 30, 2024
@SticksDeveloper
Copy link

SticksDeveloper commented Nov 30, 2024

Final Credits for everything goes to

  • Zer0Two
  • 3m377
  • Stick

Example of playing audio:

var speaker = Speaker.Create(5, new Vector3(0,0,0), true);
speaker.Play(Path.Combine(Paths.Plugins, "audio", "Audio.ogg"), 750f, 1, 500, true);

Proof of it working:
https://github.com/user-attachments/assets/a10eae7a-aa27-4053-8b94-2f6234c779d9

@Misfiy
Copy link
Member

Misfiy commented Nov 30, 2024

talked already to nameless she doesn't update it or adds anything so that's why i did a separate one

Yeah I wasn't planning to add Play or anything, so this PR is fine

@NotZer0Two
Copy link
Author

The only issue we encountered so far its not on our side but on NW Side where the audio glitches out if multiple speaker are nearby

NotZer0Two and others added 4 commits December 1, 2024 09:11
Updated Doc's and made is playing public
# Conflicts:
#	EXILED/Exiled.API/Features/Toys/Speaker.cs
EXILED/Exiled.API/Features/Toys/Speaker.cs Outdated Show resolved Hide resolved
EXILED/Exiled.API/Features/Toys/Speaker.cs Outdated Show resolved Hide resolved
EXILED/Exiled.API/Features/Toys/Speaker.cs Outdated Show resolved Hide resolved
EXILED/Exiled.API/Features/Toys/Speaker.cs Outdated Show resolved Hide resolved
EXILED/Exiled.API/Features/Toys/Speaker.cs Outdated Show resolved Hide resolved
@NotZer0Two NotZer0Two requested a review from louis1706 December 10, 2024 18:23
@Banalny-Banan
Copy link

Well now you need to solve the original issue of playback continuing after round restart

@NotZer0Two
Copy link
Author

Well now you need to solve the original issue of playback continuing after round restart

Added what you asked for...

@NotZer0Two
Copy link
Author

Like can we push it and just end this here? because its like a month of this being open and getting fixes for stuff not needed

@louis1706 louis1706 added the dependencies Pull requests that update a dependency file label Dec 10, 2024
@SticksDeveloper
Copy link

Is there anything else that needs to get changed? Sorry if I'm sounding a bit impatient, I just want to use this exiled wrapper instead of my own variation and with that a lot of code to change to replace said variation.

@VALERA771 VALERA771 changed the title Speaker Toy feat: Speaker Toy Dec 22, 2024
@louis1706 louis1706 changed the base branch from scpsl14 to dev December 23, 2024 00:02
@MS-crew
Copy link

MS-crew commented Dec 30, 2024

I'm sorry, but what's the problem? When we are going to have this pr I don't want to use a separate audio api

@3m377
Copy link

3m377 commented Dec 30, 2024

I'm sorry, but what's the problem? When we are going to have this pr I don't want to use a separate audio api

The exiled higher ups are lazy and don't want to merge it because it would require adding a new dependency

@Misfiy
Copy link
Member

Misfiy commented Dec 30, 2024

The exiled higher ups are lazy and don't want to merge it because it would require adding a new dependency

We just have other priorities, such as other projects, life and yk having a stable version, there are still bugs to fix rn.

Also as it currently stands, although minor, there is a breaking change which means this can't be merged into EXILED9 while it has that.

@VALERA771 VALERA771 requested a review from Misfiy January 1, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API dependencies Pull requests that update a dependency file Events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants