Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Exiled::API] StopDancing and StartDancing for SCP-3114 Role #189

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

NotZer0Two
Copy link

Description

Describe the changes
Adding the ability for Dancing with API

What is the current behavior? (You can also link to an open issue here)
The game by itself doesn't allow but there's left code from the client never used and so i took the variable and used it for the same reason

What is the new behavior? (if this is a feature change)
Ability to Dance

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@NotZer0Two
Copy link
Author

Don't know if i need to add IsDancing and other stuff to this let me know

@NotZer0Two
Copy link
Author

NotZer0Two commented Nov 20, 2024

And another issue while i was testing who made DanceType didn't match them with their byte

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it pls

@VALERA771
Copy link

Here should be just comment, not approval

@VALERA771 VALERA771 mentioned this pull request Nov 22, 2024
8 tasks
@NotZer0Two
Copy link
Author

Ok so i did an error in the code that made everything strange, im now using an internal value that is inside the class but actually never used

@NotZer0Two
Copy link
Author

NotZer0Two commented Nov 22, 2024

And found out that if the player has a skin can dance but only for the player who is SCP-3114 the other don't see him dance

@NotZer0Two NotZer0Two requested a review from VALERA771 November 22, 2024 18:28
@VALERA771
Copy link

VALERA771 commented Nov 23, 2024

Also in future pls use for loop with z parameter. Its just some kind of tradition <- for transpilers

@NotZer0Two
Copy link
Author

Also in future pls use for loop with z parameter. Its just some kind of tradition <- for transpilers

I can change it no problem with that

@NotZer0Two NotZer0Two changed the title [Exiled::API] StopDancing and StartDancing for SCP-3114 Role feat: [Exiled::API] StopDancing and StartDancing for SCP-3114 Role Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants