-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Exiled::API]
StopDancing and StartDancing for SCP-3114 Role
#189
base: dev
Are you sure you want to change the base?
Conversation
Don't know if i need to add IsDancing and other stuff to this let me know |
And another issue while i was testing who made DanceType didn't match them with their byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test it pls
Here should be just comment, not approval |
Ok so i did an error in the code that made everything strange, im now using an internal value that is inside the class but actually never used |
And found out that if the player has a skin can dance but only for the player who is SCP-3114 the other don't see him dance |
Also in future pls use for loop with |
I can change it no problem with that |
[Exiled::API]
StopDancing and StartDancing for SCP-3114 Role[Exiled::API]
StopDancing and StartDancing for SCP-3114 Role
Description
Describe the changes
Adding the ability for Dancing with API
What is the current behavior? (You can also link to an open issue here)
The game by itself doesn't allow but there's left code from the client never used and so i took the variable and used it for the same reason
What is the new behavior? (if this is a feature change)
Ability to Dance
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other