feat: Unbanned event addition #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis1706
requested changes
Nov 19, 2024
|
I don't think that this will work cuz you specify only 1 method to patch and it may just put 2 transpilers on same method |
|
Check |
louis1706
added
the
Requires Testing
louis1706
reviewed
Nov 22, 2024
louis1706
requested changes
Nov 22, 2024
louis1706
approved these changes
Dec 26, 2024
louis1706
requested review from
Misaka-ZeroTwo,
BoltonDev,
VALERA771 and
IRacle1
dreamsvxyz
pushed a commit
to DaybreakLabs/Vanced
that referenced
this pull request
Jan 6, 2025
* Option A * Style cop happy * Sigh stylecop * For Yamato * Done, not tested * Stylecop --------- Co-authored-by: Yamato <[email protected]>
VALERA771
added a commit
that referenced
this pull request
Jan 10, 2025
* feat: ``Lift::Get(ElevatorGroup)`` (#372) Lift::Get(ElevatorGroup) * fix: PlacingBulletHoleEventArgs::Position (#377) Fix * fix: DryFiring fired constantly (#378) Fix DryFiring fired constantly * feat: Unbanned event addition (#185) * Option A * Style cop happy * Sigh stylecop * For Yamato * Done, not tested * Stylecop --------- Co-authored-by: Yamato <[email protected]> * feat: Adding CustomKeycard for CustomItems (#98) * uwu * itemtype check * bruh bruh brrr ☠ * fix * fix * fix no.2 * some events * ExMod Team copyright --------- Co-authored-by: Yamato <[email protected]> Co-authored-by: Yamato <[email protected]> * feat: ShadowType (#382) More features for the Light wrapper * fix: remove var & fix FF for explosions * feat: DroppingAmmo, DroppedAmmo and InteractingDoor (#371) * fix: DoorType and RoomType for Checkpoint (#379) Fix DoorType and RoomType for Checkpoint * feat: CustomStats (#363) * CustomStats * replace Mathf.Clamp01 by Mathf.Clamp * Remove CustomStaminaStat.cs --------- Co-authored-by: Yamato <[email protected]> * fix: NPC Spawn using wrong SpawnType (#375) Update Npc.cs * fix: Fix FF for explosions (#383) * fix: nre fix * fix: respawningteam event fix * fix: fix explosion ff * feat: LockerType extension (#384) * feat: LockerType extension * fix: fix of fix * fix: init fix for play gun sound * Revert "fix: init fix for play gun sound" This reverts commit f4d5541. * feat: Fix OnInternalSpawning & Added ChargingJailbird setter (by BlackSerperior6) (#368) BlackSerperior6 Co-authored-by: BlackSerperior6 <[email protected]> * feat: `ExplodingGrenadeEventArgs::ExplosionType` (#385) * ExplosionType * ExplodingGrenadeEventArgs::ExplosionType --------- Co-authored-by: Yamato <[email protected]> Co-authored-by: scp252arc <[email protected]> Co-authored-by: X <[email protected]> Co-authored-by: Yamato <[email protected]> Co-authored-by: Trevlouw <[email protected]> Co-authored-by: Misfiy <[email protected]> Co-authored-by: Cosmos Zvezdochkin <[email protected]> Co-authored-by: Rysik5318 <[email protected]> Co-authored-by: BlackSerperior6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
https://discord.com/channels/656673194693885975/1307441157483270207
What is the current behavior? (You can also link to an open issue here)
Doesn't call Unban event
What is the new behavior? (if this is a feature change)
It calls Unban event now
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Not exactly. Function for this behaves differently so modifying the target is not easily done without breaking change so, just focusing on whether the player should or should not be unbanned should be sufficient.
Other information:
Not tested
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other
@louis1706 Clarify if this is what you meant