feat: Added SendingCommand event to Player

[Mar1ki]

Description

Describe the changes
Added SendingCommadnEvent, that is invoked, when player sends proper command.

What is the current behavior?
Added event, so it will be easier to contrrol commands.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[Mar1ki]

Lol, i forgot to remove my test eventarg in first commit, thats why it was not working.

[VALERA771]

I think event name should indicate that this is RA command

[Mar1ki]

Like, change it to SendingRACommand?

[Mar1ki]

Or SendingValidRACommand

[VALERA771]

Idk. It's up to you but it must properly indicate when this event fires

[Mar1ki]

Oh, ok

[VladTheCow]

PRs should target dev branch, not master

[louis1706]

i am not sure about the name SendingValidRACommandEventArgs because it's not only valid command ?
it's just any RA command right ?

[Mar1ki]

Nope, only if command exist.

[Mar1ki]

Oh, my English sucks

[VladTheCow]

Can you make sure everything works as expected?

[Mar1ki]

Yeah, i checked this on my own. Also your upper request is a little bit incorrect, the event is invoked before command execution.

[VladTheCow]

Yeah, i checked this on my own. Also your upper request is a little bit incorrect, the event is invoked before command execution.

No? Everything is fine, look at other summaries

[VALERA771]

If everyting is working as expected

[Misaka-ZeroTwo]

Personally speaking, Sending**Valid**RACommand feels a bit redundant.

[Mar1ki]

Originaly it was SendingCommand

[Mar1ki]

Wth why the build failed

outdated

[Misfiy]

Add enum for CommandType
SendingValidCommand (with CommandType) instead of only RA

[Mar1ki]

yeah, i was making the same but for client commands

[LumiFae]

@Mar1ki how is the progress going on this one, I would love this feature