Recoded Player.OnPreAuthenticating wia patch

[Mar1ki]

Description

Describe the changes
Recoded OnPreAuthenticating, event, with tanspiler.

[adarkaz]

что это за шедевральный индекс я похлопаю

[Mar1ki]

а че тебе не нравится?

[Mar1ki]

I tested this patch, and it works.

[Mar1ki]

Anyone here?

[Mar1ki]

;(

[adarkaz]

да жди ответят тебе

[VALERA771]

What will happen if you set IsAllowed to false?

[Mar1ki]

If IsAllowed set to false, the player will be kicked back to main menu, with Server Not Responding message.

[VALERA771]

Can you set it to kicked by a plugin reason?

[Mar1ki]

Yeah, you can kick player with eventargs functions.

[Mar1ki]

i mean, Not putting isallowed to false, but using ev.Reject function.

[VALERA771]

So when setting IsAllowed to false can you make that this reason will be displayed?

[Mar1ki]

No, when IsAllowed is set to false, the player is kicked with Not Responding Message. But you can kick with custom one by using ev.Reject function.

[VALERA771]

It will be better if we will specify reason when setting IsAllowed to false. Disconnecting with no actual reason is not good

[Mar1ki]

Ok, i will add this into transpiler, so it will call reject function automatically.

[Mar1ki]

And if the new property Reason is not set, it will say: "Rejected by the plugin".

[VladTheCow]

Again, PRs should target dev branch, not master

[Mar1ki]

@VladTheCow sorry but can you review?

[louis1706]

if it's work it's fine for me

[VladTheCow]

Is everything tested? As far as I know, the reject methods didn't work, but what about now?

[Mar1ki]

Yeah, i uncommented old one, they are working properly.

[Mar1ki]

Tested it on whitelist, reserved slots.

[louis1706]

~~Because of the breaking change do not merge it now ~~
I didn't seen uncommented part

[Mar1ki]

I think it is not breaking anything, couse function names are the same

[louis1706]

I think it is not breaking anything, couse function names are the same

yeah yeah i seen it after

[Misaka-ZeroTwo]

Please resolve conflicts

outdated