feat: Add RemainingDecontaminationTime property #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis1706
reviewed
Oct 19, 2024
|
This property provides the actual remaining decontamination time from the start to the end of the game. |
still my question the real time on world time or the time in game (that go a lot faster than IRL |
|
The in-game time progresses faster than real-world time. If the actual decontamination time in the game is set for 15 minutes, it will be displayed as 11 minutes in-game to reflect this faster progression accurately. This property convert to decontamination time to actual real time |
|
Pls implement yamato's suggestion, edit it if you want |
Co-authored-by: Yamato <[email protected]>
louis1706
changed the title
VALERA771
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Added a new static property RemainingDecontaminationTime to calculate the remaining time for the decontamination process.
What is the current behavior? (You can also link to an open issue here)
Currently, there is no easy way to get the remaining time for the decontamination process.
What is the new behavior? (if this is a feature change)
The new RemainingDecontaminationTime property provides an easy way to get the remaining time for the decontamination process.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, this PR does not introduce any breaking changes. It adds a new property without modifying existing functionality.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other