Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template #10

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Conversation

Misaka-ZeroTwo
Copy link
Collaborator

@Misaka-ZeroTwo Misaka-ZeroTwo commented Jul 31, 2024

Description

Describe the changes
Adds a pull request template

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Misaka-ZeroTwo Misaka-ZeroTwo self-assigned this Jul 31, 2024
@Misaka-ZeroTwo Misaka-ZeroTwo marked this pull request as draft July 31, 2024 20:11
Copy link

@iamalexrouse iamalexrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the GitHub label Aug 1, 2024
@Misaka-ZeroTwo Misaka-ZeroTwo marked this pull request as ready for review August 1, 2024 07:55
@iamalexrouse
Copy link

iamalexrouse commented Aug 1, 2024

@Misaka-ZeroTwo Could you adjust the labeler to not try to label those changes, or change the label to github (Pure Black)

@Jesus-QC Jesus-QC merged commit 5783c17 into ExMod-Team:master Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants