feat: add basic optional support for global style token module #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
roedoejet
force-pushed
the
dev.ap/gst
branch
from
3bdfd24 to
a48dcd9
Compare
joanise
reviewed
Dec 9, 2024
There was a problem hiding this comment.
If you rebase this PR and push, you'll get CI to run unit tests on this PR in the fs2 module, and you'll get code coverage analysis here.
Copyright issues - see inline comments.
I have reviewed this PR for code integration, fitting in the repo, and it looks OK on that level, but I don't feel I can review the DL elements.
Comment on lines
+4
to
+5
| # Copyright 2019 Shigeki Karita | ||
| # Apache 2.0 (http://www.apache.org/licenses/LICENSE-2.0) |
There was a problem hiding this comment.
Please update the LICENSE files both in this repo and in EV to list this new exception.
Comment on lines
+1
to
+3
| # Copyright 2020 Nagoya University (Tomoki Hayashi) | ||
| # Sourced from ESPNet2 | ||
| # Apache 2.0 (http://www.apache.org/licenses/LICENSE-2.0) |
There was a problem hiding this comment.
Ditto, needs to be reflected up in both LICENSE files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see EveryVoiceTTS/EveryVoice#605