Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .readalong format output to synthesize #607

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add .readalong format output to synthesize #607

merged 2 commits into from
Dec 10, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Dec 6, 2024

See EveryVoiceTTS/FastSpeech2_lightning#102
Also related: ReadAlongs/Studio#253

Fixes #439

This PR fetches readalong from github, because it depends on an unmerged and unpublished feature there.

This will get cleaned up in the merging process, so please review and test as is anyway.

Copy link

semanticdiff-com bot commented Dec 6, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/tests/test_configs.py  66% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  pyproject.toml Unsupported file format

Copy link
Contributor

github-actions bot commented Dec 6, 2024

CLI load time: 0:00.33
Pull Request HEAD: 45d06851fde46e00d9c917042d7174e702b4b190
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1038 |     102302 |     typer.main
import time:       291 |     121066 |   typer
import time:       244 |     100325 |       everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.cli
import time:       175 |     100943 |     everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli
import time:        18 |     100961 |   everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.preprocess
import time:      7575 |     257559 | everyvoice.cli

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.74%. Comparing base (f4c88c9) to head (45d0685).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files          46       46           
  Lines        3445     3445           
  Branches      470      470           
=======================================
  Hits         2644     2644           
  Misses        700      700           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Now that readalongs is a dependency, test_configs.py can use it without a guard.

Note that we have to enable direct ref in pyproject.toml for pip to accept to install from GitHub,
we'll have to undo that once the next version of readalongs is published.
@joanise joanise merged commit 45d0685 into main Dec 10, 2024
6 checks passed
@joanise joanise deleted the dev.ej/ras-output branch December 10, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ReadAlong export format
1 participant