[Extension Types] Add support for cross-lang extension types. #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkzinzow
force-pushed
the
clark/extension-types
branch
from
ede88bf to
6011c52
Compare
jaychia
reviewed
May 12, 2023
| @@ -5,8 +5,11 @@ prettytable-rs = "^0.10" | |||
| rand = "^0.8" | |||
|
|
|||
| [dependencies.arrow2] | |||
| branch = "clark/expand-casting-support" | |||
There was a problem hiding this comment.
Should we merge it into main in our fork before merging this PR?
There was a problem hiding this comment.
The main con with working off of main is that we'd be making the divergence from upstream Arrow2 implicit, and if we keep merging upstream Arrow2 main into our fork's main, our differing commits might be lost in the git history. Instead, I think it would be better to anchor to a branch where all of the diverging commits are at the head and try to keep the branching small/short-lived.
The flow could be:
- Create a branch on Arrow2 fork containing requisite changes to Arrow2.
- Update Daft to point to that branch.
- Submit a PR from Arrow2 fork branch to upstream Arrow2.
- If the PR is updated during the review process, we can update the locked Daft dependency with a
cargo updatePR. - When the PR is merged and is included in an Arrow2 release, switch Daft's Arrow2 dependency to point to that crates.io release.
- If we need another Arrow2 change stacked on the existing Arrow2 branch/PR, we could create a nightly snapshot branch containing both changes, similar to what Polars does: https://github.com/pola-rs/polars/blob/528590cfa57e48f5bd902ad027f5e35318644110/Cargo.toml#L47
I think this should help keep the difference with upstream Arrow2 explicit, which should be nicer? Let me know what you think about that flow.
clarkzinzow
force-pushed
the
clark/extension-types
branch
from
59b18a7 to
262b9cc
Compare
jaychia
reviewed
May 16, 2023
clarkzinzow
force-pushed
the
clark/extension-types
branch
from
8e80005 to
9bf180a
Compare
samster25
reviewed
May 17, 2023
| // TODO(Clark): Refactor to GILOnceCell in order to avoid deadlock between the below mutex and the Python GIL. | ||
| lazy_static! { | ||
| static ref REGISTRY: Mutex<HashMap<std::string::String, arrow2::datatypes::DataType>> = | ||
| Mutex::new(HashMap::new()); |
There was a problem hiding this comment.
Hmm I can see how this could lead to a deadlock with the GIL. Could be worthwhile to Fix with the GILOnceCell.
clarkzinzow
force-pushed
the
clark/extension-types
branch
2 times, most recently
from
88ddc40 to
b46c42a
Compare
clarkzinzow
force-pushed
the
clark/extension-types
branch
from
b46c42a to
7cd2205
Compare
clarkzinzow
force-pushed
the
clark/extension-types
branch
from
d5c6ea8 to
efaab36
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 86.37% 86.18% -0.20%
==========================================
Files 178 178
Lines 14415 14538 +123
==========================================
+ Hits 12451 12529 +78
- Misses 1964 2009 +45
|
samster25
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for cross-language extension types, i.e. extension types that use a language-agnostic serialization method.
TODOs