Fix improper RSA key conversion from ssh_key crate
#400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rsa` 0.9.7 introduces an error when using a key to sign (likely due to overeager validation during conversion). You can see the changes here: https://diff.rs/rsa/0.9.6/0.9.7/ This commit fixes the version back to 0.9.6 as a quick fix, although this may not be the desired solution.
|
Tracking issue: RustCrypto/RSA#463 |
EpicEric
force-pushed
the
rsa-regression
branch
from
7478fd6 to
9805a7e
Compare
This solves signatures not working in the current version of russh_keys, which were previously incorrect due to an upstream bug (see RustCrypto/SSH#318)
EpicEric
force-pushed
the
rsa-regression
branch
from
9805a7e to
263f6c7
Compare
|
I've updated this with a proper workaround while RustCrypto/SSH#318 is not merged. It turns out that the issue is in |
EpicEric
changed the title
ssh_key crate
|
Thank you for investigating this! |
| @@ -26,7 +26,7 @@ futures = "0.3" | |||
| hmac = "0.12" | |||
| log = "0.4" | |||
| rand = "0.8" | |||
| rsa = "0.9" | |||
| rsa = "=0.9.6" | |||
There was a problem hiding this comment.
I would recommend not pinning to 0.9.6 to make sure this issue doesn't occur in other code paths, given that you have a workaround now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsa0.9.7 introduces an error when using a key to sign (likely due to overeager validation during conversion). You can see the changes here: https://diff.rs/rsa/0.9.6/0.9.7/This commit fixes the version back to 0.9.6 as a quick fix, although this may not be the desired solution.