Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/minor update 1 #444

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

mimic2300
Copy link

@mimic2300 mimic2300 commented Jun 12, 2022

The first smaller update with cool features that some will surely use.
It contains these changes:

I closed the original PR because it merges badly (changes in translations and UI). But I left links to the detail of those changes.
I made a merge over the current master. Everything works.
Enjoy it.

@Soheil777
Copy link

Soheil777 commented Feb 8, 2023

Hi i have 1 request 1 new patch f you work on it
this software is the best, But it has a fundamental lack

Classification by level

maybe you think about this but it is so hard or impossible i don't know but for example
I save all of my hats (helmets) in 1 tab, But it takes a lot of time to manually sort them by level
or for relics and weapon

Is this possible for you to give us a new auto arrangement base on the level?

Thank you so much

I send same message in other place because this, you can delete one of them

55

@mimic2300
Copy link
Author

Here is a problem with merging into the main branch. Whenever I resolve conflicts, I'm still waiting for the owner to merge, so I don't enjoy the motivation to resolve conflicts over and over again, when I don't even know if it will merge...

hguy and others added 4 commits February 18, 2023 19:26
# Conflicts:
#	src/TQVaultAE.GUI/CharacterEditDialog.Designer.cs
#	src/TQVaultAE.GUI/CharacterEditDialog.cs
#	src/TQVaultAE.GUI/CharacterEditDialog.resx
#	src/TQVaultAE.GUI/Components/SackPanel.cs
#	src/TQVaultAE.Presentation/Resources.resx
Merge branch 'mimic2300:feature/item_seed_v2' into mimic2300_feature/…
@hguy
Copy link
Collaborator

hguy commented Feb 19, 2023

Hi @EtienneLamoureux ,

This PR looks OK for merging.

@EtienneLamoureux
Copy link
Owner

@hguy #432 I'm interested in. The rest are leaning very heavily into super cheaty corrupted characters. I'll hold off for now.

@ejfudd
Copy link
Contributor

ejfudd commented Feb 21, 2023

IMHO #432 is very close to the copy function. The only difference is that the original item is quickly changed.
Copy makes a copy of the item and randomizes the seed on the new item. Duplicate makes an exact copy of the item.
The original intent of those functions was to use copy to quickly make several random copies and then check them in game to see what you get since the seed algorithm is unknown.

It's not well documented what the difference is, so maybe the menu items could be changed to something like:
Copy Item (Randomized seed)
Duplicate Item (Seed unchanged)

@mimic2300
Copy link
Author

@ejfudd Forced change of item seed is the same as through the dialog, with the only difference that you do not enter the seed manually.


Other things yes. It's a bit of a cheat, but it's an old game and I wouldn't limit people with what they can or can't do. There are a lot of tools and if there is already support for copying items or changing attributes, then why the rest.
In addition, the popularity of the application will increase because it can do "everything" ;-)

@ejfudd
Copy link
Contributor

ejfudd commented Feb 21, 2023

I don't really have a dog in the race on this one, though I can offer a little historical perspective from before TQVaultAE.
TQVault was originally just an item storage utility in the vein of ATMA for Diablo 2. It was just item storage with the ability to remove relics. Cheats and character editing were the domain of SoulSeekkor's TQDefiler and we kind of stayed out of each other's lane.
The "spirit" of TQVault was always centered on the items. Over time, some cheats were added, but they were always kept item related. The cheats were also always disabled by default as some users wanted to be protected from themselves. :-)

Today, TQDefiler is abandoned, and AFAIK there is no replacement. Ultimately, it's up to Etienne and hguy whether these kinds of changes go into TQVault.

@mimic2300
Copy link
Author

Yes I agree. That's why I thought of adding these things, because there is no real replacement for a tool that is up-to-date and works.
I don't mind if there was a checkbox in the settings to allow character modifications (it already exists).
If someone wants to play fair, that's how they'll play regardless of what the application can do.

I myself got to the point several times that I finished it and didn't enjoy the grind items anymore, so I "improved" my character a little and enjoyed the day, because I would have stopped playing it for a long time anyway.

The second example is that I started playing fair, but I made a rule for myself that I would learn 3 classes (a defiler could do that, now I've added it here too) and I gave 2x skill points per level. And otherwise I played without cheats. It's just a different style of play from the start, which is interesting and enticing.

So I understand that originally the app did something else, but it's a different time. The game is old, the other tools are not very usable. So everyone plays as they want. So I hope the update will make it to the main release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants