This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
IR-3921: Copying resource should create a static-resource entry #10949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if we copy a resource in studio's file browser, it does not create an entry in static-resource table. But it updates the existing entry with new key. This PR fixes it by identifying copy operations and creating a fresh entry for them.
CITIZENDOT
requested review from
barankyle,
MoizAdnan,
hanzlamateen,
hurairahmateen and
aditya-mitra
as code owners
CITIZENDOT
changed the title
create
CITIZENDOT
changed the title
|
Nice, let's add a regression test for this please. |
barankyle
approved these changes
Aug 14, 2024
CITIZENDOT
changed the title
hanzlamateen
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if we copy/paste a resource in studio's file browser, it does not create an entry in static-resource table. But it updates the existing entry with new key. This PR fixes it by identifying copy operations and creating a fresh entry for them.
Subtasks Checklist
Breaking Changes
References
closes https://tsu.atlassian.net/browse/IR-3921
QA Steps