[DONE] Use cache to store video data #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… store video data
ptitloup
requested review from
mattbild,
Badatos,
SebastienCozeDev and
AymericJak
|
Pour les infos/doc, je suis allé voir de ce côté : https://docs.djangoproject.com/fr/3.2/topics/cache/ |
Badatos
reviewed
Oct 2, 2023
…video data instead of repeat code
AymericJak
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Je n'ai pas testé en local mais niveau code, c'est bon pour moi.
C'est une bonne idée d'utiliser les caches pour ça !
PS : dans la PR stats, j'ai retiré ça du context_processor pour le mettre dans un template tag.
J'adapterais aussi en conséquence pour utiliser les caches.
Merci pour ta PR.
Badatos
approved these changes
Oct 3, 2023
| """Function called to store video data in cache.""" | ||
| cache.delete(['DISCIPLINES', 'VIDEOS_COUNT', 'VIDEOS_DURATION', 'TYPES']) | ||
| request = None | ||
| video_data = context_video_data(request) |
There was a problem hiding this comment.
J'aurais mis directement "None" à la place de request vu qu'on ne le réutilise pas, mais sinon OK pour moi ;)
There was a problem hiding this comment.
Ok , j'ai egalement fixé un petit bug qui ne supprimait pas les données puisqu'il fallait utiliser delete_many.
SebastienCozeDev
approved these changes
Oct 3, 2023
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 22, 2023
* Use cache to store video data - get it in context - create command to store video data * change name of video context processor * add some pydoc * update cache timeout to 600 seconds - use DRY and call context cache video data instead of repeat code * use delete many to clear cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending your pull request, make sure the following are done :
developbranch.[WIP]or[DONE].