Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] live event - export valeur vers conf + cast propriété #959

Merged
merged 3 commits into from
Sep 22, 2023
Merged

[DONE] live event - export valeur vers conf + cast propriété #959

merged 3 commits into from
Sep 22, 2023

Conversation

mattbild
Copy link
Collaborator

  • Export vers le fichier de configuration de la valeur par défaut du max attempt du fichier live/utils.py.
  • Cast d'un message d'une exception renvoyé en json

@mattbild mattbild changed the title live event - export valeur vers conf + cast propriété [DONE] live event - export valeur vers conf + cast propriété Sep 22, 2023
@LoicBonavent LoicBonavent self-requested a review September 22, 2023 14:37
Badatos
Badatos approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK pr moi ;)

LoicBonavent
LoicBonavent approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@LoicBonavent LoicBonavent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK pour moi aussi :)

ptitloup
ptitloup approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi

@ptitloup ptitloup merged commit 3867f66 into EsupPortail:develop Sep 22, 2023
@mattbild mattbild mentioned this pull request Sep 25, 2023
Merged
@mattbild mattbild deleted the max_attempt branch October 9, 2023 08:57
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 22, 2023
@mattbild @vsabatie
[DONE] live event - export valeur vers conf + cast propriété (EsupPor…
e4fdb59 
…tail#959)

* max attempt

* export param dans fichier de config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoicBonavent LoicBonavent LoicBonavent approved these changes

@Badatos Badatos Badatos approved these changes

@ptitloup ptitloup ptitloup approved these changes

Assignees

@mattbild mattbild

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattbild @ptitloup @Badatos @LoicBonavent