Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Fix migrations for 3.4.0 #957

Merged
merged 5 commits into from
Sep 22, 2023
Merged

[DONE] Fix migrations for 3.4.0 #957

merged 5 commits into from
Sep 22, 2023

Conversation

AymericJak
Copy link
Contributor

@AymericJak AymericJak commented Sep 22, 2023 •
edited
Loading

  • Changement de la limite du mot de passe dans le modèle Video 80 --> 250.
  • Simplification d'expressions du code
  • Correction du date_time (datetime naïf --> datetime conscient)
  • Utilisation de bulk_update pour la création des playlists favoris
  • Fix du mot de passe qui pouvait être encrypté plusieurs fois

@AymericJak AymericJak added the bug Something isn't working label Sep 22, 2023
@AymericJak AymericJak requested a review from ptitloup September 22, 2023 09:13
@AymericJak AymericJak self-assigned this Sep 22, 2023
@AymericJak AymericJak changed the title [WIP] Fix migrations for 3.4.0 [DONE] Fix migrations for 3.4.0 Sep 22, 2023
@AymericJak AymericJak marked this pull request as ready for review September 22, 2023 13:36
ptitloup
ptitloup requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

une petite remarque sur le nb_batch = 1000

pod/playlist/apps.py Outdated
)
favorites_playlists_to_create.append(playlist)
playlist_id += 1
Playlist.objects.bulk_create(favorites_playlists_to_create)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention, il faut rajouter un batch_size sinon, on risque le timeout sur de grandes instances : , batch_size=nb_batch avec nb_batch = 1000 (voir pod/video/apps.py L.190 et L.233)

ptitloup
ptitloup approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ptitloup ptitloup merged commit 50801f7 into EsupPortail:develop Sep 22, 2023
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 22, 2023
@AymericJak @vsabatie
[DONE] Fix migrations for 3.4.0 (EsupPortail#957)
ad6519a 
* Improve code & change constraint of video password

* Optimisation of favorites playlist creation

* Fix favorites migration

* Fix password encryption

* Add batch_size
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 23, 2023
@AymericJak @vsabatie
[DONE] Fix migrations for 3.4.0 (EsupPortail#957)
a371a84 
* Improve code & change constraint of video password

* Optimisation of favorites playlist creation

* Fix favorites migration

* Fix password encryption

* Add batch_size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitloup ptitloup ptitloup approved these changes

Assignees

@AymericJak AymericJak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AymericJak @ptitloup