Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] RGAA 03.02 #951

Merged
merged 7 commits into from
Sep 21, 2023
Merged

[DONE] RGAA 03.02 #951

merged 7 commits into from
Sep 21, 2023

Conversation

Badatos
Copy link
Collaborator

@Badatos Badatos commented Sep 20, 2023

RGAA 03.02

Dans chaque page web, le contraste entre la couleur du texte et la couleur de son arrière-plan est-il suffisamment élevé (hors cas particuliers) ?

P02

https://pod-test.univ-cotedazur.fr/contact_us/?video=3&subject=inappropriate_content

Non-conformité :

  • Certains éléments textuels ont un contraste insuffisant avec leur arrière-plan (4.5:1) ou n’ont pas une taille suffisante pour un contraste de (3:1), par exemple :
    • l'astérisque rouge dans le menu latéral droit : ratio de 4,15:1 au lieu de 4,5:1

P10

https://pod-test.univ-cotedazur.fr/video/edit/0004-podmp3/

Voir P2

P11

https://pod-test.univ-cotedazur.fr/channels/edit/chaine-koena-accessibilite-numerique/

Voir P2

P16

https://pod-test.univ-cotedazur.fr/meeting/

Non-conformité :

  • Certains éléments textuels ont un contraste insuffisant avec leur arrière-plan (4.5:1) ou n’ont pas une taille suffisante pour un contraste de (3:1), par exemple le bouton "démarrez la réunion" en noir sur fond vert #1F7C85 avec un ratio de 4,3:1

Other fix:

  • add "getfromvideo" in tabindex navigation
  • clean some useless css rule
  • Use boostrap to collapse relevant help message in completion forms
  • Render some submit as visually-hidden-focusable in aside menu
  • Add missing Title in Channel list modal
  • Use ngettext to translate plurals in ajax-display-channels.js
  • Correct languages typo
  • remove duplicated aria-hidden
  • correct wrong id on playlist-modal
  • replace p by div in video-info

* clean some useless css rule
* Use boostrap to collapse relevant help message in completion forms
* Render some submit as visually-hidden-focusable in aside menu
* Add missing Title in Channel list modal
* Use ngettext to translate plurals in ajax-display-channels.js
* Correct languages typo
# Conflicts:
#	pod/locale/fr/LC_MESSAGES/django.po
#	pod/locale/fr/LC_MESSAGES/djangojs.po
#	pod/locale/nl/LC_MESSAGES/django.po
#	pod/locale/nl/LC_MESSAGES/djangojs.po
@Badatos Badatos self-assigned this Sep 20, 2023
@Badatos Badatos marked this pull request as ready for review September 21, 2023 08:22
@Badatos Badatos changed the title [WIP] RGAA 03.02 [DONE] RGAA 03.02 Sep 21, 2023
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi, merci !

@AymericJak AymericJak added the enhancement New feature or request label Sep 21, 2023
+ remove duplicated aria-hidden
+ correct wrong id on playlist-modal
+ replace p by div in video-info
Copy link
Contributor

@AymericJak AymericJak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit problème de traduction concernant la modale chaines :

image

Aussi écrit "channel list" lors du chargement.

Sinon, rien d'autre à dire :)

@Badatos
Copy link
Collaborator Author

Badatos commented Sep 21, 2023

Petit problème de traduction concernant la modale chaines :

image

Aussi écrit "channel list" lors du chargement.

Sinon, rien d'autre à dire :)

oui je n'ai pas encore envoyé les .mo compilés, j'attendais de savoir laquelle de ma PR ou la tienne serait mergée en 1er pour éviter les conflits ^^

@AymericJak
Copy link
Contributor

Petit problème de traduction concernant la modale chaines :
image
Aussi écrit "channel list" lors du chargement.
Sinon, rien d'autre à dire :)

oui je n'ai pas encore envoyé les .mo compilés, j'attendais de savoir laquelle de ma PR ou la tienne serait mergée en 1er pour éviter les conflits ^^

Bien vu en effet !
C'est malin :)

# Conflicts:
#	pod/locale/fr/LC_MESSAGES/django.po
#	pod/locale/fr/LC_MESSAGES/djangojs.po
#	pod/locale/nl/LC_MESSAGES/django.po
#	pod/locale/nl/LC_MESSAGES/djangojs.po
Copy link
Contributor

@AymericJak AymericJak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est tout bon pour moi !

Merci bien :)

Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi !

@ptitloup ptitloup merged commit 84406de into EsupPortail:develop Sep 21, 2023
4 checks passed
@Badatos Badatos deleted the feature/RGAA_03.02 branch September 21, 2023 14:50
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 22, 2023
* * add "getfromvideo" in tabindex navigation
* clean some useless css rule
* Use boostrap to collapse relevant help message in completion forms
* Render some submit as visually-hidden-focusable in aside menu
* Add missing Title in Channel list modal
* Use ngettext to translate plurals in ajax-display-channels.js
* Correct languages typo

* Remove merge artifacts

* correct a typo in ajax-display
+ remove duplicated aria-hidden
+ correct wrong id on playlist-modal
+ replace p by div in video-info

* update .po lang files

* Push Compiled .mo lang files
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 23, 2023
* * add "getfromvideo" in tabindex navigation
* clean some useless css rule
* Use boostrap to collapse relevant help message in completion forms
* Render some submit as visually-hidden-focusable in aside menu
* Add missing Title in Channel list modal
* Use ngettext to translate plurals in ajax-display-channels.js
* Correct languages typo

* Remove merge artifacts

* correct a typo in ajax-display
+ remove duplicated aria-hidden
+ correct wrong id on playlist-modal
+ replace p by div in video-info

* update .po lang files

* Push Compiled .mo lang files
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 23, 2023
* * add "getfromvideo" in tabindex navigation
* clean some useless css rule
* Use boostrap to collapse relevant help message in completion forms
* Render some submit as visually-hidden-focusable in aside menu
* Add missing Title in Channel list modal
* Use ngettext to translate plurals in ajax-display-channels.js
* Correct languages typo

* Remove merge artifacts

* correct a typo in ajax-display
+ remove duplicated aria-hidden
+ correct wrong id on playlist-modal
+ replace p by div in video-info

* update .po lang files

* Push Compiled .mo lang files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants