Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Fix some bugs for 3.4.0 #947

Merged
merged 20 commits into from
Sep 21, 2023
Merged

[DONE] Fix some bugs for 3.4.0 #947

merged 20 commits into from
Sep 21, 2023

Conversation

AymericJak
Copy link
Contributor

@AymericJak AymericJak commented Sep 18, 2023 •
edited
Loading

  • Ajout d’un lien dans le breadcrumb, pour le champs Home
  • Correction d'un bug pour le sort direction des playlists quand il y avait moins de 2 playlists
  • Correction d'un problème avec les migrations (lorsque l'on faisait une migration, les playlists Favoris étaient créées dans tous les cas, rappel : il ne peut y avoir qu'une seule playlist favoris par utilisateur) TESTÉ DEPUIS MASTER
  • Le mot de passe d'une vidéo protégée était sauvegardé en clair dans la base de données)
  • Correction des notes d'une vidéo où une erreur 500 était retournée lors de la modification ou la suppression
  • Erreur dans la console sur la page d'import d'une vidéo externe
  • Lors du changement de vidéo dans une playlist, l'icône lecture en cours ▶ est bien mise à jour + modification du hover
  • Ajout aria-hidden=true pour certaines balises <i>
  • Correction d'un bug qui empêchait d'appliquer le filtre "Voir les playlists protégées par un mot de passe"
  • En dark mode, le logo est maintenant de la bonne couleur

@AymericJak AymericJak added the bug Something isn't working label Sep 18, 2023
@AymericJak AymericJak self-assigned this Sep 18, 2023
@AymericJak AymericJak marked this pull request as ready for review September 21, 2023 09:48
@AymericJak AymericJak changed the title [WIP] Fix some bugs for 3.4.0 [DONE] Fix some bugs for 3.4.0 Sep 21, 2023
Badatos
Badatos requested changes Sep 21, 2023
View reviewed changes
pod/video/templates/channel/channel.html Outdated
<a href="feed://{{ request.META.HTTP_HOST }}{% url 'rss-video:rss-video' slug_c=channel.slug slug_t=theme.slug %}" title="{% trans 'subscribe to the video feed'%}" target="_blank" class="btn btn btn-outline-primary btn-sm"><i class="bi bi-rss"></i>&nbsp;Video</a>
<a href="feed://{{ request.META.HTTP_HOST }}{% url 'rss-video:rss-audio' slug_c=channel.slug slug_t=theme.slug%}" title="{% trans 'subscribe to the audio feed'%}" target="_blank" class="btn btn btn-outline-primary btn-sm"><i class="bi bi-rss"></i>&nbsp;Audio</a>
<a href="feed://{{ request.META.HTTP_HOST }}{% url 'rss-video:rss-video' slug_c=channel.slug slug_t=theme.slug %}" title="{% trans 'Subscribe to the video feed'%}" target="_blank" class="btn btn btn-outline-primary btn-sm" data-bs-toggle="tooltip" data-bs-placement="bottom">
<i class="bi bi-rss" aria-hidden="true"></i>&nbsp;Video
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il manque une balise {% trans %} autour de "Video"

pod/video/templates/channel/channel.html Show resolved Hide resolved
pod/video/templates/videos/videos.html Outdated
<a href="feed://{{ request.META.HTTP_HOST }}{% url 'rss-video:rss-video'%}?{{request.GET.urlencode}}" title="{% trans 'subscribe to the video feed'%}" target="_blank" class="btn btn-outline-primary btn-sm">
<i class="bi bi-rss"></i>&nbsp;Video</a>
<a href="feed://{{ request.META.HTTP_HOST }}{% url 'rss-video:rss-audio'%}?{{request.GET.urlencode}}" title="{% trans 'Subscribe to the audio feed'%}" target="_blank" class="btn btn-outline-primary btn-sm" data-bs-toggle="tooltip" data-bs-placement="bottom">
<i class="bi bi-rss" aria-hidden="true"></i>&nbsp;Audio
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il manque une balise {% trans %} autour de "Audio"

  • idem ci-dessous

@AymericJak AymericJak requested a review from Badatos September 21, 2023 12:07
Badatos
Badatos requested changes Sep 21, 2023
View reviewed changes
pod/video/templates/channel/channel.html Outdated Show resolved Hide resolved
pod/video/templates/channel/channel.html Outdated Show resolved Hide resolved
ptitloup
ptitloup requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deux petites améliorations

pod/playlist/apps.py Outdated Show resolved Hide resolved
pod/video/apps.py Outdated Show resolved Hide resolved
@ptitloup
Copy link
Contributor

petit pb flake8 ;)

ptitloup
ptitloup approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi !

Badatos
Badatos approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour toutes ces corrections !
C'est bon pour moi niveau code :)

@ptitloup ptitloup merged commit 1a2953e into EsupPortail:develop Sep 21, 2023
4 checks passed
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 22, 2023
@AymericJak @vsabatie
[DONE] Fix some bugs for 3.4.0 (EsupPortail#947)
8f679ad 
* Add breadcrumb link for Home

* Fix sort direction when less than 2 videos

* Fix playlist migration

* Add password encryption for protected videos

* Fix flake8

* Improve password input

* Fix unittest

* Fix video notes

* Fix JS error for import video page

* Fix playlist player refresh

* Title improvements and aria-hidden for <i>

* Fix playlist sort redirection, dark mode contrasts

* Fix playlist migration

* Improve QoC

* Fix flake8

* Add missing translations

* Add missing translations

* Improve migration functions

* Remove useless import
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 23, 2023
@AymericJak @vsabatie
[DONE] Fix some bugs for 3.4.0 (EsupPortail#947)
0f4cc8c 
* Add breadcrumb link for Home

* Fix sort direction when less than 2 videos

* Fix playlist migration

* Add password encryption for protected videos

* Fix flake8

* Improve password input

* Fix unittest

* Fix video notes

* Fix JS error for import video page

* Fix playlist player refresh

* Title improvements and aria-hidden for <i>

* Fix playlist sort redirection, dark mode contrasts

* Fix playlist migration

* Improve QoC

* Fix flake8

* Add missing translations

* Add missing translations

* Improve migration functions

* Remove useless import
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 23, 2023
@AymericJak @vsabatie
[DONE] Fix some bugs for 3.4.0 (EsupPortail#947)
c6ddf03 
* Add breadcrumb link for Home

* Fix sort direction when less than 2 videos

* Fix playlist migration

* Add password encryption for protected videos

* Fix flake8

* Improve password input

* Fix unittest

* Fix video notes

* Fix JS error for import video page

* Fix playlist player refresh

* Title improvements and aria-hidden for <i>

* Fix playlist sort redirection, dark mode contrasts

* Fix playlist migration

* Improve QoC

* Fix flake8

* Add missing translations

* Add missing translations

* Improve migration functions

* Remove useless import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Badatos Badatos Badatos approved these changes

@ptitloup ptitloup ptitloup approved these changes

@SebastienCozeDev SebastienCozeDev Awaiting requested review from SebastienCozeDev

Assignees

@AymericJak AymericJak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AymericJak @ptitloup @Badatos