Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Updates to APP6-B Stylx #315

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Updates to APP6-B Stylx #315

merged 1 commit into from
Mar 23, 2018

Conversation

BobBooth
Copy link
Contributor

This is an updated stylx to fix issues in APP6-B symbology.
Relates to Issue #276 , and others.

Description

These are changes to the SICs and symbols in the stylx for APP6-B support.

Related Issue

Issue #9
Issue #88
Issue #85
Issue #215
Issue #73
Issue #291

Motivation and Context

Various symbology issues had been reported/discovered. Other updates to the comprehensive test data reduced some of them, but many were related to incorrect or duplicate SICs, missing or broken symbols in the app6b stylx file. This commit has the latest version of the stylx with these issues corrected.

How Has This Been Tested?

Testing via @csmoore Runtime Symbol export app, and via visual inspection in ArcGIS Pro 2.0.0 style editor, and inspection of test data by CMoore in Pro 2.2.

Screenshots (if appropriate):

Multiple screen shots in
Issue #9
Issue #88
Issue #85
Issue #215
Issue #73
Issue #291

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

This is an updated stylx to fix issues in APP6-B symbology.
Relates to Issue #276 , and others.
@BobBooth BobBooth added the F-APP-6(B) Issues pertaining to APP-6(B) label Mar 21, 2018
@BobBooth
Copy link
Contributor Author

@csmoore @ACueva @dfoll @topowright - here is the updated Stylx with the APP6-B fixes. Please merge.

@csmoore
Copy link
Member

csmoore commented Mar 22, 2018

Gave a quick sanity check with Comprehensive Pro 2.2 Project and didn't see any obvious issues.

Specific symbol issues will be verified with: #9, #73, #88, #85, #215, #291

image

image

Copy link
Member

@csmoore csmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick/sanity check looked good on Pro 2.2 and Runtime 100.2

@csmoore
Copy link
Member

csmoore commented Mar 22, 2018

I believe this is ready to merge but will leave PR open in case @topowright @dfoll @ACueva want to verify open issues prior to merge - otherwise feel free to merge when ready

@ACueva ACueva merged commit ea770f8 into dev Mar 23, 2018
@ACueva ACueva deleted the BB-#276-App6B_Stylx_fixes branch March 23, 2018 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F-APP-6(B) Issues pertaining to APP-6(B)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants