This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
2525D C1 Update #381
Open
2525D C1 Update #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From @mepler
joebayles
commented
Oct 24, 2017
| <rect x="268.5" y="348.5" fill="#FFFFFF" stroke="#231F20" stroke-width="5" stroke-miterlimit="10" width="19.46" height="90.75"/> | ||
| <rect x="351.5" y="365.5" fill="#FFFFFF" stroke="#231F20" stroke-width="5" stroke-miterlimit="10" width="15" height="57"/> | ||
| <rect x="243.4" y="387.5" fill="#FFFFFF" stroke="#231F20" stroke-width="5" stroke-miterlimit="10" width="136.56" height="14"/> | ||
| <path id="_106699768" d="M269.44,405.12h12.96v32.52h-12.96V405.12z M360.52,414.84h-6.6v-9.72h6.48v9.72H360.52z M250,398.64v-6.6 |
There was a problem hiding this comment.
@mepler - Requires fill
joebayles
commented
Oct 24, 2017
| <line id="mod1_1_" display="inline" fill="none" stroke="#0000FF" stroke-width="2" x1="203.966" y1="346.985" x2="406.199" y2="346.705"/> | ||
| </g> | ||
| <g id="mod1"> | ||
| <text transform="matrix(1 0 0 1 244.5 340.5)" font-family="'ArialMT'" font-size="60">CYB</text> |
There was a problem hiding this comment.
Font is identified as ArialMT but looks serif.
joebayles
commented
Oct 24, 2017
svg/Appendices/Air/01110117.svg
Outdated
| @@ -20,6 +20,6 @@ | |||
| </g> | |||
| </g> | |||
| <g id="main"> | |||
| <text transform="matrix(1 0 0 1 194.999 423.7715)" font-family="sans-serif" font-size="72">ASUW</text> | |||
| <text transform="matrix(1 0 0 1 196.999 423.7715)" font-family="'ArialMT'" font-size="72">ASUW</text> | |||
There was a problem hiding this comment.
Font is identified as ArialMT but looks serif.
joebayles
commented
Oct 24, 2017
svg/Appendices/Air/01120000.svg
Outdated
| @@ -21,6 +21,6 @@ | |||
| </g> | |||
| <g id="main"> | |||
|
|
|||
| <text transform="matrix(1 0 0 1 208.0005 439.25)" fill="#FFFFFF" stroke="#000000" stroke-width="5" font-family="sans-serif" font-size="116.5535">CIV</text> | |||
| <text transform="matrix(1 0 0 1 208.0005 439.25)" fill="#FFFFFF" stroke="#000000" stroke-width="5" font-family="'ArialMT'" font-size="116.5535">CIV</text> | |||
There was a problem hiding this comment.
Font is identified as ArialMT but looks serif.
joebayles
commented
Oct 24, 2017
svg/Appendices/Air/mod1/01411.svg
Outdated
| <line id="mod1_1_" display="inline" fill="none" stroke="#0000FF" stroke-width="2" x1="203.966" y1="346.985" x2="406.199" y2="346.705"/> | ||
| </g> | ||
| <g id="mod1"> | ||
| <text transform="matrix(1 0 0 1 244.5 340.5)" font-family="'ArialMT'" font-size="60">CYB</text> |
There was a problem hiding this comment.
Font is identified as ArialMT but looks serif.
- Replaced ArialMT with sans-serif - Removed double quotations "''"
Capturing some errant changes
|
Checking @joebayles comment above about the fonts, it looks like a few of the svg files may still have the proprietary (TimesNewRoman, Arial, etc.) vs. generic font family (serif, sans-serif) in this PR, example |
|
I must have missed those files that still have proprietary fonts. Feel free to continue the work. |
Updated and new SVGs PNGs
Fixes #397
Filled out the leading zeroes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @mepler
This will require an extensive review.
Fixes #456, #457