Only load featurelayer tiles after metadata has been loaded #1372
Conversation
This can have a significant impact on performance for larger layers, where the initial detailed tiles are requested concurrently with the metadata request and thus loaded in arcgis format -- assuming isModern hasn't been manually set -- and need to be converted to geojson (which can choke a browser). This is only a partial fix, as _setView can also trigger _update.
|
Thanks for the PR. |
There was a problem hiding this comment.
This fix looks good on the surface but it means that sub-classes of FeatureGrid are now responsible for calling the initial _update when they are ready to start loading features.
The issue is that there are TONS of cases were things will happen that will start loading features before we are ready. For example what if the user pans or zooms after loading a layer but before we know if it supports GeoJSON or not?
I'll have to give a think on this. I'm leaning towards just making isModern enabled by default now. f=geojson has been supported since ArcGIS Server 10.4 (source) which was officially deprecated in February 2022 (lifecycle doc) so I think we could probably make GeoJSON the default now and avoid this issue.
This would however be a breaking change and require a major version bump.
|
@patrickarlt Thanks for looking at this, that all makes sense. One thing that would still be affected is the Esri/esri-leaflet-renderers; I found that early polygons are unstyled, until you zoom in or otherwise load more. It's a tricky problem though, that's why I only called this a partial fix! Update: I just realised that the custom renderers repo was archived a few hours ago, so perhaps that's not a priority! |
|
@markhepburn closing this in favor of #1376. Thanks for bringing this up. In the meantime I would just manually set Yes @gavinr-maps and I decided to archive |
|
@patrickarlt Quite understand, thanks for taking the time to look at this. What's the current recommended platform for incorporating esri feature service layers (with styling), out of curiosity? We picked Leaflet for various reasons including excellent React bindings, but it's getting harder to support non-image formats such as ESRI or pbf. |
This would be the official ArcGIS Maps SDK for JavaScript which supports everything you can configure in the map viewer and ArcGIS Pro and as a bonus also gives you full web map support which is too large in scope for us to build for Esri Leaflet. Keep and eye out for some announcements this month with regard to some new releases which should hopefully make integration with 3rd party frameworks easier. |
This can have a significant impact on performance for larger layers, where the initial detailed tiles are requested concurrently with the metadata request and thus loaded in arcgis format -- assuming isModern hasn't been manually set -- and need to be converted to geojson (which can choke a browser).
This is only a partial fix, as _setView can also trigger _update.
A potential fix for this is an instance variable to check whether metadata has loaded yet (tricky as metadata is requested in a subclass), or some proxy for this -- I have been using "_cells is empty or not", but there may be a better way, and I'm possibly missing cases as well.