Ab/leaf2 migration #2478
Draft
Ab/leaf2 migration #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
reviewed
Jan 23, 2025
Comment on lines
+694
to
+699
| self.migrate_anchor_leaf().await?; | ||
| self.migrate_da_proposals().await?; | ||
| self.migrate_vid_shares().await?; | ||
| self.migrate_undecided_state().await?; | ||
| self.migrate_quorum_proposals().await?; | ||
| self.migrate_quorum_certificates().await |
There was a problem hiding this comment.
Can we gate this by versions(and the other parts we start storing the new types) so we can merge this and not worry about deploying it
ss-es
reviewed
Jan 24, 2025
Comment on lines
+702
to
+719
| async fn migrate_anchor_leaf(&self) -> anyhow::Result<()> { | ||
| Ok(()) | ||
| } | ||
| async fn migrate_da_proposals(&self) -> anyhow::Result<()> { | ||
| Ok(()) | ||
| } | ||
| async fn migrate_vid_shares(&self) -> anyhow::Result<()> { | ||
| Ok(()) | ||
| } | ||
| async fn migrate_undecided_state(&self) -> anyhow::Result<()> { | ||
| Ok(()) | ||
| } | ||
| async fn migrate_quorum_proposals(&self) -> anyhow::Result<()> { | ||
| Ok(()) | ||
| } | ||
| async fn migrate_quorum_certificates(&self) -> anyhow::Result<()> { | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
I think all of these should be fully implemented in the same PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: