jf-pcs build regression: pin rust 1.83 #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sveitser
commented
Jan 14, 2025
•
sveitser
commented
- Use toolchain toml file from nix flake to also pin the same rust version in the nix dev env.
- Update flake.lock to include latest rust versions.
- Upstream issue: Compilation taking unexpected long after 1.84 rust-lang/rust#135457
- Use toolchain toml file from nix flake to also pin the same rust version in the nix dev env. - Update flake.lock to include latest rust versions.
sveitser
requested review from
philippecamacho,
ImJeremyHe,
jbearer,
tbro and
imabdulbasit
as code owners
imabdulbasit
approved these changes
Jan 14, 2025
- The foundry upgrade breaks bindings generation. - The solc upgrade changes bytecode/bindings, bloating this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.