Jb/l1 client #2434
Merged
Jb/l1 client #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
tbro and
imabdulbasit
as code owners
rob-maron
approved these changes
Jan 7, 2025
There are many reasons to avoid using WebSockets for regular RPC requests. Some of these reasons are enumerated [here](https://docs.alchemy.com/reference/best-practices-for-using-websockets-in-web3#reasons-to-use-https-instead-of-websockets-for-json-rpc-node-requests) This change reorganizes the L1 client so that instead of having an HTTP provider _or_ a WebSockets provider, we have both. The HTTP provider is used for regular RPC requests and the WebSockets provider is used for subscriptions only. Each type of provider is now doing what it does best, and this is evidenced in the code changes: * we delete the complicated reconnect handling for WebSockets on failed RPC requests. HTTP was never subject to this complexity because each request is already a separate connection * we no longer need stub methods for subscriptions for HTTP provider because we are no longer trying to present a unified interface that can be implemented by HTTP or WebSockets * the timeout logic for subscriptions, while still in the code, is less important because it never affected WebSockets in the first place We have kept the WebSockets provider as optional, since not all providers support WebSockets. In case it is not provided, we will fall back to the old HTTP polling-based implementation of subscriptions, which is why we need to keep the timeout logic in there. See #2360
Allow the L1 client to be configured with multiple RPC provider URLs. Fail over to the next provider in the list if * two requests fail in a given time period * N requests fail in a row Handle rate limit errors specially by preventing requests to the provider until the rate limit period expires. Closes #2360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2360
Closes #1238
This PR: