Add LightClientArbitrum #2423
Add LightClientArbitrum #2423
Conversation
Sneh1999
force-pushed
the
fix-light-client-contract-for-arb-sepolia
branch
from
d47f297 to
5746ef8
Compare
Sneh1999
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
|
additionally, we'll need to create another issue to deal with adding upgradeable deployment scripts for LightClientArbitrum.sol and upgrading LightClient.sol. In that issue, we should consider versioning as mentioned here https://github.com/EspressoSystems/espresso-sequencer/blob/main/doc/smart-contract-upgrades.md |
|
| function setUp() public { | ||
| vm.createSelectFork("https://arb1.arbitrum.io/rpc"); | ||
| mockArbsys = new MockArbSys(); | ||
| vm.etch(address(100), address(mockArbsys).code); // Replace address(100) with mock |
There was a problem hiding this comment.
Note: this is important because foundry doesnt support arbitrum pre-compiles so we have to mock them in tests
Sneh1999
force-pushed
the
fix-light-client-contract-for-arb-sepolia
branch
from
3b0577c to
56ab328
Compare
…into fix-light-client-contract-for-arb-sepolia
There was a problem hiding this comment.
lgtm!
we'd need to add the LightClientArbitrum contract to the just gen-bindings command but that can be handled in the next github issue #2436
Replacing block.number in arbitrum because it returns the block number of eth instead of arbitrum
Discussion here