Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2372 stake table add tests to the withdrawfunds function #2394

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

2372 stake table add tests to the withdrawfunds function #2394

wants to merge 28 commits into from
+620 −103

Conversation

alysiahuggins
Copy link
Contributor

Closes #2372

This PR:

  • add withdrawFunds tests,
  • removed epoch logic until from withdrawFunds function until epochs are implemented,
  • removed unnecessary checks from the withdrawFunds function

This PR does not:

Key places to review:

  • withdrawFunds() function and its related tests

How to test this PR:

forge test --match-contract StakeTable

@alysiahuggins
add stake table tests
978cd8f
@alysiahuggins
remove stake types
2bc6d75
@alysiahuggins
verify token allowance, balance and reprioritize verification order o…
c8812ef 
…n registration
@alysiahuggins
set the fixed stake amount, added related tests, updated data types
e33bf9b
@alysiahuggins
add more verification checks to the withdraw function
7bd7f4b
@alysiahuggins
updated errror types
2b2411c
@alysiahuggins
Merge branch 'main' into 2304-stake-table-registration
d7a352d
@alysiahuggins
added TODO statements in comments to be explicit about outdated funct…
584e320 
…ions that need to be updated to the new spec
@alysiahuggins
a validator/node is identified by the msg.sender, blskey and schnorrk…
59c2109 
…ey. todo: add tests
@alysiahuggins
Merge branch 'main' into 2304-stake-table-registration
23b0fb0
@alysiahuggins
Merge branch '2304-stake-table-registration' into 2370-staketable-upd…
ec4b02b 
…ate-validator-identification-keys
@alysiahuggins
merged from the fixed stake branch and modified test to include the i…
9777b99 
…nclusion of the blsKey
@alysiahuggins
not required to get the blsSig for a withdrawal since we have the eth…
b9c7022 
… account the validator registered with
@alysiahuggins
add the ability to update consensus keys
9303444
@alysiahuggins
add the ability to update consensus keys
3a264c1
@alysiahuggins
merge with main
955a69d
@alysiahuggins
remove vscode settings
1f171dd
@alysiahuggins
add test or happy path of updating consensus keys
f237074
@alysiahuggins
added unhappy path tests on based on no key changes and changed the b…
8800893 
…lsVK comparison to field by field comparison so that it is more efficient and more obvious what is going on
@alysiahuggins
added comment to newly added function on StakeTable and added tests t…
cee5a6f 
…hat have been commented out for now
@alysiahuggins
change the lookup node and lookup stake functions to use their ethere…
f8c0210 
…um address, update related implementations and add tests
@alysiahuggins
updated updateConsensusKeys function, enhance test coverage
5124d9d
@alysiahuggins
added todo
6a34dae
@alysiahuggins
Merge branch 'main' into 2370-staketable-update-validator-identificat…
548b28c 
…ion-keys
@alysiahuggins
updated test to use the new seed so that a new schnorr key could be g…
5df564c 
…enerated
@alysiahuggins
Merge branch '2370-staketable-update-validator-identification-keys' i…
f5ffee2 
…nto 2372-stake-table-add-tests-to-the-withdrawfunds-function
@alysiahuggins
add withdrawFunds tests, removed epoch logic until from withdrawFunds…
3ad4a14 
… function until epochs are implemented, removed unecessary checks from the withdrawFunds function
@alysiahuggins alysiahuggins linked an issue Dec 12, 2024 that may be closed by this pull request
Stake Table: Add tests to the withdrawFunds function #2372
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stake Table: Add tests to the withdrawFunds function
1 participant
@alysiahuggins