Ensure consistency of decide events #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
tbro and
imabdulbasit
as code owners
|
Tested on a water node that was having this issue. Also deployed and tested on decaf |
jbearer
force-pushed
the
jb/archival-decides
branch
from
66c3d9d to
1df8311
Compare
tbro
approved these changes
Nov 1, 2024
The logic for moving data from consensus storae to archive storage was sometimes generating an invalid decide event, because it made a chain of non-consecutive leaves originating from multiple separate events. This fixes the issue and prevents it from happening again by generating a separate decide event for each leaf in consensus storage. Also adds a regression test.
jbearer
force-pushed
the
jb/archival-decides
branch
from
1df8311 to
34d641a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for moving data from consensus storae to archive storage was sometimes generating an invalid decide event, because it made a chain of non-consecutive leaves originating from multiple separate events. This fixes the issue and prevents it from happening again by generating a separate decide event for each leaf in consensus storage.
Also adds a regression test.