[cpp] avoid null pointer deference in PhysicsConstraintTimeline #2694
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsdk123
reviewed
Nov 28, 2024
| @@ -95,6 +95,7 @@ void PhysicsConstraintResetTimeline::apply(Skeleton &skeleton, float lastTime, f | |||
| else { | |||
| Vector<PhysicsConstraint *> &physicsConstraints = skeleton.getPhysicsConstraints(); | |||
| for (size_t i = 0; i < physicsConstraints.size(); i++) { | |||
| constraint = physicsConstraints[i]; | |||
| if (constraint->_active) constraint->reset(); | |||
There was a problem hiding this comment.
I'd think you also want to if (constraint && constraint->_active)
There was a problem hiding this comment.
There isn't a null check above either, or in other places where these are used. My assumption would be that getPhysicsConstraints returns a vector of non-null pointers so if you're within its size the check isn't necessary. If that's not the case happy to add the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling spine-cpp with mingw and -Werror results in:
This looks like a real issue as
constraintis definitely null here. The intent seems pretty clear though so here's a quick fix - feel free to throw it away and fix it a different way.