fix errors

benchexec/tablegenerator/react-table/src/components/NavSync.js

@@ -6,29 +6,27 @@
 // SPDX-License-Identifier: Apache-2.0
 
 import { useMemo } from "react";
-import { useNavigationType } from "react-router-dom";
-
-// This component is used to sync the navigation URL of POP events
-// This component does not render anything, and is a workaround to use a hook in the parent class component.
-// This logic should be moved to the parent class component in the future after the same is converted to a functional component.
+import { useLocation } from "react-router-dom";
 
 /*
+ * A functional component to sync the filters display from the URL
+ * This component does not render anything, and is a workaround to use a hook in the parent class component.
+ * This logic should be moved to the parent class component in the future after the same is converted to a functional component.
+ *
  * @param {Object} props - The props object
  * @param {Function} props.updateState - The function to update the state of the parent component
  * @param {Function} props.updateFiltersFromUrl - The function to update the filters from the URL
  */
 const NavSync = (props) => {
-  const navType = useNavigationType();
+  const location = useLocation();
   useMemo(() => {
     props.updateState();
-    if (navType === "POP") {
-      props.updateFiltersFromUrl();
-    }
+    props.updateFiltersFromUrl();
 
-    // We only want to update the state of the parent component when the navigation type changes
+    // We only want to update the state of the parent component when the window location changes
     // and not when the other props change due to rerendering of the parent component
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [navType]);
+  }, [location]);
 
   return null;
 };

benchexec/tablegenerator/react-table/src/components/Overview.js

@@ -170,10 +170,11 @@ export default class Overview extends React.Component {
       });
 
   componentDidMount() {
-    this.updateState();
+    this.updateFiltersFromUrl();
     this.setState({
       mounted: true,
     });
+    this.updateState();
   }
 
   getFiltersFromUrl = () => {
@@ -246,7 +247,7 @@ export default class Overview extends React.Component {
       clearImmediate(this.lastImmediate);
     }
     this.lastImmediate = setImmediate(() => {
-      this.filterUrlSetter(filter);
+      this.filterUrlSetter(filter, window.history);
       this.lastFiltered = filter.filter(
         (item) => (item.values && item.values.length > 0) || item.value,
       );

benchexec/tablegenerator/react-table/src/components/SelectColumn.js

@@ -67,7 +67,7 @@ export default class SelectColumn extends React.Component {
       hiddenParams["hidden"] = null;
     }
 
-    setURLParameter(hiddenParams);
+    setURLParameter(hiddenParams, window.history);
   }
 
   // -------------------------Rendering-------------------------

benchexec/tablegenerator/react-table/src/tests/QuantilePlot.test.js

@@ -21,11 +21,8 @@ const fs = require("fs");
  * @returns {void}
  */
 const updateURLParams = (params) => {
-  window.history.pushState(
-    {},
-    "Quantile Plot Test",
-    constructHashURL(window.location.href, params),
-  );
+  const { newUrl } = constructHashURL(window.location.href, params);
+  window.history.pushState({}, "Quantile Plot Test", newUrl);
 };
 
 const testDir = "../test_integration/expected/";
@@ -95,7 +92,9 @@ files
       });
 
       describe("Direct Plot should match HTML snapshot", () => {
+        console.log(window.location.href);
         updateURLParams({ plot: plotInstance.plotOptions.direct });
+        console.log(window.location.href);
 
         it.each(selectionResultInput)(
           "with selection of the type %s and %s results",

benchexec/tablegenerator/react-table/src/tests/ScatterPlot.test.js

@@ -9,7 +9,7 @@ import React from "react";
 import ScatterPlot from "../components/ScatterPlot.js";
 import Overview from "../components/Overview";
 import renderer from "react-test-renderer";
-import { setURLParameter } from "../utils/utils";
+import { constructHashURL } from "../utils/utils";
 const fs = require("fs");
 
 const content = fs.readFileSync(
@@ -170,6 +170,7 @@ function getSelections(xSelection, ySelection) {
 }
 
 function setUrlParams(params) {
-  setURLParameter(params);
+  const { newUrl } = constructHashURL(window.location.href, params);
+  window.history.pushState({}, "Quantile Plot Test", newUrl);
   plotInstance.refreshUrlState();
 }

benchexec/tablegenerator/react-table/src/utils/utils.js

@@ -271,20 +271,16 @@ export const constructHashURL = (url, params = {}) => {
  * It can also be used to remove a parameter from the URL by setting it's value to undefined.
  *
  * @param {Object} params - The parameters to be set or updated in the URL hash
- * @param {Object} [history=null] - The history object to use for updating the URL hash
+ * @param {Object} [history=undefined] - The history object to update the URL hash without reloading the page
  * @returns {void}
  */
-const setURLParameter = (params = {}, history = null) => {
-  const { newUrl, queryString } = constructHashURL(
-    document.location.href,
-    params,
-  );
-  if (history && history.push) {
-    history.push(queryString);
+const setURLParameter = (params = {}, history = undefined) => {
+  const { newUrl } = constructHashURL(window.location.href, params);
+  if (history && history.pushState) {
+    history.pushState({}, "", newUrl);
     return;
   }
-  document.location.assign(newUrl);
-  // document.location.href = newUrl;
+  window.location.href = newUrl;
 };
 
 const makeUrlFilterDeserializer = (statusValues, categoryValues) => {