Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYSTEMTIME Support to BinConvert #65

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

reece394
Copy link
Contributor

@reece394 reece394 commented Aug 22, 2024

Description

I added the ability to convert Registry Key Values to SYSTEMTIME. This is based off the code I borrowed from the Data Interpreter in Registry Explorer with minor edits (I figured if it works why reinvent the wheel). This is needed so I can add LogonStats to DFIRBatch. Below is a preview of it working.

image

Checklist:

Please replace every instance of [ ] with [X] OR click on the checkboxes after you submit your PR

  • I have generated a unique GUID for my Batch file(s)
  • I have tested and validated the new Batch file(s) against test data and achieved the desired output
  • I have placed the Batch file(s) within the .\RECmd\BatchExamples directory
  • I have set or updated the version of my Batch file(s)
  • I have made an attempt to document the artifacts within the Batch file(s)
  • I have consulted the Guide/Template to ensure my Map(s) follow the same format

Thank you for your submission and for contributing to the DFIR community!

@AndrewRathbun
Copy link
Collaborator

@reece394 are there any other formats available to add support for that would make sense to put in the effort for? I imagine the data interpreter has all the options available to us? I know we have a good amount of heavy hitters so far but curious if there are any other glaring omissions.

@reece394
Copy link
Contributor Author

reece394 commented Sep 1, 2024

When I had a look through we will probably need DOS FAT Time Date / DOS FAT Time Date and OLE 2.0 Date Time as well at some point.

I was going to test these at some point in the future when I had more time. Unfortunately I won’t be able to contribute too much for the next while

But yeah honestly it wouldn’t be too much effort to take all the conversions from the data interpreter and add them to there since with the code already written it should be a quick copy paste job with some minor edits

@AndrewRathbun
Copy link
Collaborator

One other thing I've always wanted was lookup tables similar to EvtxECmd. Rather than use comments to resolve values, we could actually interpret and resolve values.

@reece394
Copy link
Contributor Author

reece394 commented Sep 1, 2024

This sounds like a great idea to implement in a future version. Would definitely be more flexible than the current implementation. Might take a bit of effort to integrate that in though

@AndrewRathbun AndrewRathbun self-assigned this Sep 2, 2024
@EricZimmerman EricZimmerman merged commit 5cdd091 into EricZimmerman:master Sep 3, 2024
1 check passed
@EricZimmerman
Copy link
Owner

changes pushed to binaries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants