Move GoodSignal from Service.lua to its own file

[ccuser44]

Move GoodSignal from Service.lua to its own file and add license to comply with law

[coasterteam]

Lacks the additional backwards compatibility that was setup with the in-Service version, will review with changes later today when I get time

[Dimenpsyonal]

Indeed

[ccuser44]

Lacks the additional backwards compatibility that was setup with the in-Service version, will review with changes later today when I get time

I did a diffcheck and the only changes were the removals of Signal:ConnectOnce, Signal:connectOnce, Signal:wait, Signal:fire, Signal:connect, connection:Fire, connection:fire, connection:disconnect, connection:wait, Event = {}, and Signal:Destroy.
I am not sure why the removal of these would make the compatibility any better so I decided to keep them.

[coasterteam]

This was due to GoodSignal being the replacement of the old wrapped BindableEvents. They had those methods existing so I didn't want to break existing events someone might have/use.

[ccuser44]

This was due to GoodSignal being the replacement of the old wrapped BindableEvents. They had those methods existing so I didn't want to break existing events someone might have/use.

But wouldn't removal exactly break said existing events? This pull doesn't remove anything but the one in Service.lua does.

[coasterteam]

I modified GoodSignal with additional methods as wrapped BindableEvents were removed from the Events system. I am not sure how this is confusing?

[ccuser44]

I modified GoodSignal with additional methods as wrapped BindableEvents were removed from the Events system. I am not sure how this is confusing?

So do I remove the added methods?

[coasterteam]

Added reviewed changes to ensure backwards compatibility with the events system this was replacing.

[ccuser44]

Added reviewed changes to ensure backwards compatibility with the events system this was replacing.

I merged the suggestions now.

I somehow thought that the additions were actually in the vanilla GoodSignal and were removed in Adonis for compatibility but apparently it was the other way around.

Anyways it's fixed now.

[Dimenpsyonal]

Very cool