Remove invariant loads on primal computation #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Mar 5, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
4366
to
4367
|
|
||
| mod, meta = GPUCompiler.codegen(:llvm, primal_job; optimize=false, toplevel=toplevel, cleanup=false, validate=false, parent_job=parent_job) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| mod, meta = GPUCompiler.codegen(:llvm, primal_job; optimize=false, toplevel=toplevel, cleanup=false, validate=false, parent_job=parent_job) | |
| mod, meta = GPUCompiler.codegen( | |
| :llvm, | |
| primal_job; | |
| optimize=false, | |
| toplevel=toplevel, | |
| cleanup=false, | |
| validate=false, | |
| parent_job=parent_job, | |
| ) |
| @@ -4366,6 +4366,9 @@ function GPUCompiler.codegen(output::Symbol, job::CompilerJob{<:EnzymeTarget}; | |||
|
|
|||
| mod, meta = GPUCompiler.codegen(:llvm, primal_job; optimize=false, toplevel=toplevel, cleanup=false, validate=false, parent_job=parent_job) | |||
| prepare_llvm(mod, primal_job, meta) | |||
| for f in functions(mod) | |||
| permit_inlining!(f) | |||
| end | |||
|
|
|||
| LLVM.ModulePassManager() do pm | |||
| API.AddPreserveNVVMPass!(pm, #=Begin=#true) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| API.AddPreserveNVVMPass!(pm, #=Begin=#true) | |
| API.AddPreserveNVVMPass!(pm, true) #=Begin=# |
There was a problem hiding this comment.
@vchuravy @simsurace so I actually disagree with this part of the autoformatter, since I would very much like to know what that arg corresponds to (as presently specified with a comment).
What's the right way to do so in-format?
There was a problem hiding this comment.
Hmm, good question. It seems to be a known issue domluna/JuliaFormatter.jl#562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we were running this already, but somehow it might have decayed off?