TA pass julia type info via param attr #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 75.93% 75.68% -0.26%
==========================================
Files 35 35
Lines 10543 10507 -36
==========================================
- Hits 8006 7952 -54
- Misses 2537 2555 +18 ☔ View full report in Codecov by Sentry. |
|
On @swilliamson7 this seems to yield another 50s improvement from 187->132 We still spent most of our time in type-tree.
Across those three towers we spend: 83s out of 132s in constructing the type-tree. The closest other thing is ~10s in julia_activity_rule |
|
Do you know what Julia code is calling all the constructions (specifically
the hot regions)
…On Tue, Feb 20, 2024 at 11:28 PM Valentin Churavy ***@***.***> wrote:
On @swilliamson7 <https://github.com/swilliamson7> this seems to yield
another 50s improvement from 187->132
We still spent most of our time in type-tree.
image.png (view on web)
<https://github.com/EnzymeAD/Enzyme.jl/assets/145258/5effb262-a407-4e6f-a691-b21bd6db80f7>
image.png (view on web)
<https://github.com/EnzymeAD/Enzyme.jl/assets/145258/fe376526-eab9-4de9-a414-f3776fb31f38>
Across those three towers we spend: 83s out of 132s in constructing the
type-tree. The closest other thing is ~10s in julia_activity_rule
—
Reply to this email directly, view it on GitHub
<#1300 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXDYZQJGFZLGQJHXH5TYUVZWHAVCNFSM6AAAAABDR4LYTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVHA3DSNJQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Specifically I want to understand whether these functions are called too
many times or if they are too slow
…On Wed, Feb 21, 2024 at 7:45 AM Billy Moses ***@***.***> wrote:
Do you know what Julia code is calling all the constructions (specifically
the hot regions)
On Tue, Feb 20, 2024 at 11:28 PM Valentin Churavy <
***@***.***> wrote:
> On @swilliamson7 <https://github.com/swilliamson7> this seems to yield
> another 50s improvement from 187->132
>
> We still spent most of our time in type-tree.
>
> image.png (view on web)
> <https://github.com/EnzymeAD/Enzyme.jl/assets/145258/5effb262-a407-4e6f-a691-b21bd6db80f7>
>
> image.png (view on web)
> <https://github.com/EnzymeAD/Enzyme.jl/assets/145258/fe376526-eab9-4de9-a414-f3776fb31f38>
>
> Across those three towers we spend: 83s out of 132s in constructing the
> type-tree. The closest other thing is ~10s in julia_activity_rule
>
> —
> Reply to this email directly, view it on GitHub
> <#1300 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJTUXDYZQJGFZLGQJHXH5TYUVZWHAVCNFSM6AAAAABDR4LYTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVHA3DSNJQGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| shadow_init = job.config.params.shadowInit | ||
| ctx = context(mod) | ||
| dl = string(LLVM.datalayout(mod)) | ||
| dl = string(LLVM.datalayout(mod)) | ||
|
|
||
| tt = [TT.parameters[2:end]...,] |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| tt = [TT.parameters[2:end]...,] | |
| tt = [TT.parameters[2:end]...] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires EnzymeAD/Enzyme#1746