Throw descriptive AsssertionError instead of @show + @assert inside of create_abi_wrapper

[devmotion]

I just ran into

(actualRetType, literal_rt, rettype) = (actualRetType, literal_rt, rettype) = (actualRetType, literal_rt, rettype) = Gradient - enzyme: Error During Test at REPL[5]:1
  Got exception outside of a @test
  task switch not allowed from inside staged nor pure functions
  Stacktrace:
    [1] try_yieldto(undo::typeof(Base.ensure_rescheduled))
      @ Base ./task.jl:910
    [2] wait()
      @ Base ./task.jl:984
    [3] uv_write(s::Base.TTY, p::Ptr{UInt8}, n::UInt64)
      @ Base ./stream.jl:1048
    [4] unsafe_write(s::Base.TTY, p::Ptr{UInt8}, n::UInt64)
      @ Base ./stream.jl:1120
    [5] write
      @ ./strings/io.jl:244 [inlined]
    [6] print
      @ ./strings/io.jl:246 [inlined]
    [7] print(::Base.TTY, ::String, ::String, ::Vararg{String})
      @ Base ./strings/io.jl:46
    [8] println(::Base.TTY, ::String, ::Vararg{String})
      @ Base ./strings/io.jl:75
    [9] println(::String, ::String)
      @ Base ./coreio.jl:4
   [10] create_abi_wrapper(enzymefn::LLVM.Function, TT::Type, rettype::Type, actualRetType::Type, Mode::Enzyme.API.CDerivativeMode, augmented::Nothing, width::Int64, returnPrimal::Bool, shadow_init::Bool, world::UInt64, interp::Enzyme.Compiler.Interpreter.EnzymeInterpreter)
      @ Enzyme.Compiler ~/.julia/packages/Enzyme/KJgKj/src/compiler.jl:3255
...

Based on the stacktrace I assume that the problem is the use of @show instead of @safe_show (as a few lines below) in the create_abi_wrapper function.

By the way, is there any typical problem (or error on my side) when hitting this branch?

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ba58bcb) 75.13% compared to head (22edb01) 75.14%.

Files	Patch %	Lines
src/compiler.jl	0.00%	4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1262   +/-   ##
=======================================
  Coverage   75.13%   75.14%           
=======================================
  Files          35       35           
  Lines       10397    10393    -4     
=======================================
- Hits         7812     7810    -2     
+ Misses       2585     2583    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[devmotion]

Are the test errors on Ubuntu related to this PR? At least I didn't see them on the main branch.

[devmotion]

By the way, is there any typical problem (or error on my side) when hitting this branch?

@wsmoses just wondering if there's some experience/knowledge you can share regarding these allocatedinline checks?

[wsmoses]

It basically is an assert that type inference inside enzyme should be compatible (aka if by refewnice or not) with the type inference result passed into enzyme

…

On Thu, Feb 1, 2024 at 8:28 AM David Widmann ***@***.***> wrote: By the way, is there any typical problem (or error on my side) when hitting this branch? @wsmoses <https://github.com/wsmoses> just wondering if there's some experience/knowledge you can share regarding these allocatedinline checks? — Reply to this email directly, view it on GitHub <#1262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJTUXHZ6N2OY5NHYBMYLYDYRNG4PAVCNFSM6AAAAABCTJNY4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQG43DEMRTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[devmotion]

And if the assertion fails, is it usually an issue with my code or in Enzyme?

[wsmoses]

It's sufficiently rare/weird that I don't know

…

On Thu, Feb 1, 2024, 11:53 AM David Widmann ***@***.***> wrote: And if the assertion fails, is it usually an issue with my code or in Enzyme? — Reply to this email directly, view it on GitHub <#1262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJTUXDIRQAIK65J2NPMXE3YRNXZXAVCNFSM6AAAAABCTJNY4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGA2DOMJTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>