Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom rules overwritten fix #1258

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Custom rules overwritten fix #1258

merged 2 commits into from
Jan 29, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jan 28, 2024

Fixes: #1242

@wsmoses wsmoses force-pushed the cover branch 2 times, most recently from 4fc2a81 to 9913e52 Compare January 29, 2024 00:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3095a4f) 74.66% compared to head (ee11f53) 75.13%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/rules/customrules.jl 90.47% 2 Missing ⚠️
src/compiler/optimize.jl 98.78% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   74.66%   75.13%   +0.46%     
==========================================
  Files          34       35       +1     
  Lines       10300    10397      +97     
==========================================
+ Hits         7691     7812     +121     
+ Misses       2609     2585      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit ba58bcb into main Jan 29, 2024
43 of 45 checks passed
@wsmoses wsmoses deleted the cover branch January 29, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble writing custom rule in Enzyme: AssertionError: !(overwritten[end])
2 participants