Fix cholesky part 2 #1256
Merged
Fix cholesky part 2 #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
+ Coverage 74.53% 74.69% +0.16%
==========================================
Files 35 35
Lines 10311 10314 +3
==========================================
+ Hits 7685 7704 +19
+ Misses 2626 2610 -16 ☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Jan 28, 2024
| @@ -696,11 +697,11 @@ function EnzymeRules.augmented_primal(config, func::Const{typeof(cholesky)}, RT: | |||
| nothing | |||
| else | |||
| if EnzymeRules.width(config) == 1 | |||
| Cholesky(Matrix(fact), 'L', 0) | |||
| Enzyme.make_zero(fact) | |||
There was a problem hiding this comment.
AFAICT this will also create a Cholesky object with the same uplo char as fact? One issue I had noticed (but unfortunately had no time to open an issue) is that on main always L is used.
There was a problem hiding this comment.
correct this is what it would do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254