Cleanup and simplify cholesky handler #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
force-pushed
the
choleskyfix
branch
2 times, most recently
from
7c70801 to
13d97b0
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
+ Coverage 73.96% 74.53% +0.57%
==========================================
Files 35 35
Lines 10356 10310 -46
==========================================
+ Hits 7660 7685 +25
+ Misses 2696 2625 -71 ☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Jan 27, 2024
|
The definitions were in place so I’m not sure they would’ve applied?
Feel free to try an open an issue with.
…On Sat, Jan 27, 2024 at 1:29 PM David Widmann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/internal_rules.jl
<#1251 (comment)>:
>
-function EnzymeRules.forward(
- func::Const{typeof(\)},
It seems the PR removed rules for \ - doesn't this break support for
StaticArrays and other arrays that cannot be mutated in-place?
—
Reply to this email directly, view it on GitHub
<#1251 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXBDZQ3XUM4LCNVKW7LYQVBSJAVCNFSM6AAAAABCMRM5BWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBXGE2TCOJZHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Most of the time static arrays don’t require custom rules (I don’t think we
have any for) as they write functions entirely in Julia rather than calling
BLAS.
Whether they would be helpful, as opposed to necessary, however is a
different question that should be answered with benchmarks.
…On Sat, Jan 27, 2024 at 2:17 PM Billy Moses ***@***.***> wrote:
The definitions were in place so I’m not sure they would’ve applied?
Feel free to try an open an issue with.
On Sat, Jan 27, 2024 at 1:29 PM David Widmann ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/internal_rules.jl
> <#1251 (comment)>:
>
> >
> -function EnzymeRules.forward(
> - func::Const{typeof(\)},
>
> It seems the PR removed rules for \ - doesn't this break support for
> StaticArrays and other arrays that cannot be mutated in-place?
>
> —
> Reply to this email directly, view it on GitHub
> <#1251 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJTUXBDZQ3XUM4LCNVKW7LYQVBSJAVCNFSM6AAAAABCMRM5BWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBXGE2TCOJZHA>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.