Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linsolv to have const args #1121

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Allow linsolv to have const args #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5121adb
Allow linsolv to have const args
wsmoses Nov 1, 2023
6967483
Add tests
wsmoses Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 32 additions & 18 deletions src/internal_rules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,18 +337,6 @@ function EnzymeRules.augmented_primal(config, func::Const{typeof(\)}, ::Type{RT}
else
res
end

dAs = if EnzymeRules.width(config) == 1
(A.dval,)
else
A.dval
end

dbs = if EnzymeRules.width(config) == 1
(b.dval,)
else
b.dval
end

cache_b = if EnzymeRules.overwritten(config)[3]
copy(b.val)
Expand Down Expand Up @@ -394,21 +382,47 @@ function EnzymeRules.reverse(config, func::Const{typeof(\)}, ::Type{RT}, cache,
end

dAs = if EnzymeRules.width(config) == 1
(A.dval,)
if typeof(A) <: Const
(nothing,)
else
(A.dval,)
end
else
A.dval
if typeof(A) <: Const
ntuple(Val(EnzymeRules.width(config))) do i
Base.@_inline_meta
nothing
end
else
A.dval
end
end

dbs = if EnzymeRules.width(config) == 1
(b.dval,)
if typeof(b) <: Const
(nothing,)
else
(b.dval,)
end
else
b.dval
if typeof(b) <: Const
ntuple(Val(EnzymeRules.width(config))) do i
Base.@_inline_meta
nothing
end
else
b.dval
end
end

for (dA, db, dy) in zip(dAs, dbs, dys)
z = transpose(cache_A) \ dy
dA .-= z * transpose(y)
db .+= z
if !(typeof(A) <: Const)
dA .-= z * transpose(y)
end
if !(typeof(b) <: Const)
db .+= z
end
dy .= eltype(dy)(0)
end

Expand Down
32 changes: 32 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2510,4 +2510,36 @@ end
y = A \ b
@test dA ≈ (-z * transpose(y))
@test db ≈ z

db = zero(b)

forward, pullback = Enzyme.autodiff_thunk(ReverseSplitNoPrimal, Const{typeof(\)}, Duplicated, Const{typeof(A)}, Duplicated{typeof(b)})

tape, primal, shadow = forward(Const(\), Const(A), Duplicated(b, db))

dy = Float64[17, 19]
copyto!(shadow, dy)

pullback(Const(\), Const(A), Duplicated(b, db), tape)

z = transpose(A) \ dy

y = A \ b
@test db ≈ z

dA = zero(A)

forward, pullback = Enzyme.autodiff_thunk(ReverseSplitNoPrimal, Const{typeof(\)}, Duplicated, Duplicated{typeof(A)}, Const{typeof(b)})

tape, primal, shadow = forward(Const(\), Duplicated(A, dA), Const(b))

dy = Float64[17, 19]
copyto!(shadow, dy)

pullback(Const(\), Duplicated(A, dA), Const(b), tape)

z = transpose(A) \ dy

y = A \ b
@test dA ≈ (-z * transpose(y))
end
Loading