Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linsolv to have const args #1121

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Allow linsolv to have const args #1121

merged 2 commits into from
Nov 2, 2023

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Nov 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (20d439d) 76.51% compared to head (6967483) 76.43%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
- Coverage   76.51%   76.43%   -0.08%     
==========================================
  Files          27       27              
  Lines        9400     9408       +8     
==========================================
- Hits         7192     7191       -1     
- Misses       2208     2217       +9     
Files Coverage Δ
src/internal_rules.jl 3.78% <0.00%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit 19811ea into main Nov 2, 2023
30 of 42 checks passed
@wsmoses wsmoses deleted the wsmoses-patch-1 branch November 2, 2023 02:36
michel2323 pushed a commit that referenced this pull request Nov 7, 2023
* Allow linsolv to have const args

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants